Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1148073005: Use luci-config for infrequently changing settings, part 2. (Closed)

Created:
5 years, 6 months ago by Vadim Sh.
Modified:
5 years, 6 months ago
Reviewers:
nodir
CC:
chromium-reviews
Base URL:
git@github.com:luci/luci-py@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use luci-config for infrequently changing settings, part 2. Introduce config.proto and make group importer configuration to use ASCII proto serialization instead of JSON. R=nodir@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/2e6d1d7437a2c9dd4a9fa2c5203192890a62e94a

Patch Set 1 : make-import-config-proto #

Patch Set 2 : keep old config around #

Total comments: 16

Patch Set 3 : #

Patch Set 4 : fix pylint (??!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -158 lines) Patch
M appengine/auth_service/config.py View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M appengine/auth_service/handlers_frontend.py View 1 chunk +5 lines, -5 lines 0 comments Download
M appengine/auth_service/handlers_frontend_test.py View 1 2 4 chunks +26 lines, -25 lines 0 comments Download
M appengine/auth_service/importer.py View 1 2 3 chunks +131 lines, -81 lines 0 comments Download
M appengine/auth_service/importer_test.py View 1 5 chunks +90 lines, -24 lines 0 comments Download
A + appengine/auth_service/proto/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A appengine/auth_service/proto/config.proto View 1 2 1 chunk +50 lines, -0 lines 0 comments Download
A appengine/auth_service/proto/config_pb2.py View 1 chunk +183 lines, -0 lines 0 comments Download
M appengine/auth_service/static/js/config_page.js View 2 chunks +2 lines, -9 lines 0 comments Download
M appengine/components/components/auth/ui/rest_api.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M appengine/components/components/auth/ui/templates/base.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M appengine/components/components/datastore_utils/config.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M appengine/components/tools/compile_proto.py View 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vadim Sh.
ptal deployed here: https://1435-f1ab804-tainted-vadimsh-dot-chrome-infra-auth-dev.appspot.com/auth/config
5 years, 6 months ago (2015-05-30 00:19:28 UTC) #1
nodir
Did not finish reviewing yet https://codereview.chromium.org/1148073005/diff/20001/appengine/auth_service/importer.py File appengine/auth_service/importer.py (right): https://codereview.chromium.org/1148073005/diff/20001/appengine/auth_service/importer.py#newcode166 appengine/auth_service/importer.py:166: raise ValueError('A system is ...
5 years, 6 months ago (2015-06-02 00:19:21 UTC) #2
Vadim Sh.
https://codereview.chromium.org/1148073005/diff/20001/appengine/auth_service/importer.py File appengine/auth_service/importer.py (right): https://codereview.chromium.org/1148073005/diff/20001/appengine/auth_service/importer.py#newcode166 appengine/auth_service/importer.py:166: raise ValueError('A system is imported twice') On 2015/06/02 00:19:20, ...
5 years, 6 months ago (2015-06-02 00:52:18 UTC) #3
Vadim Sh.
https://codereview.chromium.org/1148073005/diff/20001/appengine/auth_service/proto/config.proto File appengine/auth_service/proto/config.proto (right): https://codereview.chromium.org/1148073005/diff/20001/appengine/auth_service/proto/config.proto#newcode22 appengine/auth_service/proto/config.proto:22: // a subdirectory in the tarball. On 2015/06/02 00:52:17, ...
5 years, 6 months ago (2015-06-02 00:54:18 UTC) #4
nodir
lgtm https://codereview.chromium.org/1148073005/diff/20001/appengine/auth_service/importer.py File appengine/auth_service/importer.py (right): https://codereview.chromium.org/1148073005/diff/20001/appengine/auth_service/importer.py#newcode175 appengine/auth_service/importer.py:175: raise ValueError('Group %r is imported twice' % str(plainlist.group)) ...
5 years, 6 months ago (2015-06-02 16:52:29 UTC) #5
Vadim Sh.
5 years, 6 months ago (2015-06-02 18:39:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
2e6d1d7437a2c9dd4a9fa2c5203192890a62e94a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698