Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1908)

Unified Diff: appengine/auth_service/config.py

Issue 1148073005: Use luci-config for infrequently changing settings, part 2. (Closed) Base URL: git@github.com:luci/luci-py@master
Patch Set: fix pylint (??!) Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/auth_service/handlers_frontend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/auth_service/config.py
diff --git a/appengine/auth_service/config.py b/appengine/auth_service/config.py
index 1977acfb90e928f00d8fb0e96e64426387ba52df..8473513451880e01845a23842519a1fb9ac5d636 100644
--- a/appengine/auth_service/config.py
+++ b/appengine/auth_service/config.py
@@ -2,7 +2,7 @@
# Use of this source code is governed by the Apache v2.0 license that can be
# found in the LICENSE file.
-"""Adapter between luci-config client and the rest of auth_service."""
+"""Adapter between config service client and the rest of auth_service."""
import logging
@@ -10,19 +10,19 @@ from components import config
def is_remote_configured():
- """True if luci-config backend URL is defined.
+ """True if config service backend URL is defined.
- If luci-config backend URL is not set auth_service will use datastore
+ If config service backend URL is not set auth_service will use datastore
as source of truth for configuration (with some simple web UI to change it).
- If luci-config backend URL is set, UI for config management will be read only
- and all config changes must be performed through luci-config.
+ If config service backend URL is set, UI for config management will be read
+ only and all config changes must be performed through the config service.
"""
return bool(get_remote_url())
def get_remote_url():
- """Returns URL of luci-config service if configured, to display in UI."""
+ """Returns URL of a config service if configured, to display in UI."""
settings = config.ConfigSettings.cached()
if settings and settings.service_hostname:
return 'https://%s' % settings.service_hostname
@@ -30,7 +30,7 @@ def get_remote_url():
def refetch_config():
- """Refetches all configs from luci-config (if enabled).
+ """Refetches all configs from a config service (if enabled).
Called as a cron job.
"""
« no previous file with comments | « no previous file | appengine/auth_service/handlers_frontend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698