Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1147843003: Set WebKeyboardEvent.domCode on Windows. (Closed)

Created:
5 years, 7 months ago by kpschoedel
Modified:
5 years, 7 months ago
Reviewers:
sadrul, Wez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set WebKeyboardEvent.domCode on Windows. BUG=489446 Committed: https://crrev.com/81c9cea98d67819b6b2a9d5a7a2c9a31eecbd06f Cr-Commit-Position: refs/heads/master@{#330586}

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/browser/renderer_host/web_input_event_aura.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/web_input_event_aura_unittest.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147843003/1
5 years, 7 months ago (2015-05-19 18:27:24 UTC) #2
kpschoedel
5 years, 7 months ago (2015-05-19 18:29:29 UTC) #4
kpschoedel
… sorry, initially set the coomit message from 166833 rather than 489446
5 years, 7 months ago (2015-05-19 18:36:14 UTC) #5
Wez
LGTM, FWIW
5 years, 7 months ago (2015-05-19 18:45:19 UTC) #7
sadrul
rs lgtm
5 years, 7 months ago (2015-05-19 18:46:29 UTC) #8
Wez
On 2015/05/19 18:45:19, Wez wrote: > LGTM, FWIW Is it possible to add a simple ...
5 years, 7 months ago (2015-05-19 18:46:50 UTC) #9
kpschoedel
On 2015/05/19 18:46:50, Wez wrote: > On 2015/05/19 18:45:19, Wez wrote: > > LGTM, FWIW ...
5 years, 7 months ago (2015-05-19 18:56:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147843003/20001
5 years, 7 months ago (2015-05-19 18:57:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 19:45:51 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 19:46:37 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81c9cea98d67819b6b2a9d5a7a2c9a31eecbd06f
Cr-Commit-Position: refs/heads/master@{#330586}

Powered by Google App Engine
This is Rietveld 408576698