Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1770)

Unified Diff: content/browser/renderer_host/web_input_event_aura_unittest.cc

Issue 1147843003: Set WebKeyboardEvent.domCode on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/web_input_event_aura.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/web_input_event_aura_unittest.cc
diff --git a/content/browser/renderer_host/web_input_event_aura_unittest.cc b/content/browser/renderer_host/web_input_event_aura_unittest.cc
index 4f2cc7a64ab9a2d33e5a803cfe1a9171aba34305..9f0cf473a73395a72dcaaa54bfd04eb98f38763e 100644
--- a/content/browser/renderer_host/web_input_event_aura_unittest.cc
+++ b/content/browser/renderer_host/web_input_event_aura_unittest.cc
@@ -32,6 +32,8 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) {
// However, modifier bit for Control in |webkit_event| should be set.
EXPECT_EQ(blink::WebInputEvent::ControlKey | blink::WebInputEvent::IsLeft,
webkit_event.modifiers);
+ EXPECT_EQ(static_cast<int>(ui::DomCode::CONTROL_LEFT),
+ webkit_event.domCode);
}
{
// Release Ctrl.
@@ -40,6 +42,8 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) {
blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event);
// However, modifier bit for Control in |webkit_event| shouldn't be set.
EXPECT_EQ(blink::WebInputEvent::IsLeft, webkit_event.modifiers);
+ EXPECT_EQ(static_cast<int>(ui::DomCode::CONTROL_LEFT),
+ webkit_event.domCode);
}
#if defined(USE_X11)
const int kLocationModifiers =
« no previous file with comments | « content/browser/renderer_host/web_input_event_aura.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698