Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: content/browser/renderer_host/web_input_event_aura_unittest.cc

Issue 1147843003: Set WebKeyboardEvent.domCode on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/renderer_host/web_input_event_aura.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/web_input_event_aura.h" 5 #include "content/browser/renderer_host/web_input_event_aura.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 #include "ui/events/event.h" 9 #include "ui/events/event.h"
10 #include "ui/events/event_utils.h" 10 #include "ui/events/event_utils.h"
(...skipping 14 matching lines...) Expand all
25 // crbug.com/127142 25 // crbug.com/127142
26 TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) { 26 TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) {
27 { 27 {
28 // Press Ctrl. 28 // Press Ctrl.
29 ui::KeyEvent event(ui::ET_KEY_PRESSED, ui::VKEY_CONTROL, 29 ui::KeyEvent event(ui::ET_KEY_PRESSED, ui::VKEY_CONTROL,
30 ui::DomCode::CONTROL_LEFT, ui::EF_CONTROL_DOWN); 30 ui::DomCode::CONTROL_LEFT, ui::EF_CONTROL_DOWN);
31 blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event); 31 blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event);
32 // However, modifier bit for Control in |webkit_event| should be set. 32 // However, modifier bit for Control in |webkit_event| should be set.
33 EXPECT_EQ(blink::WebInputEvent::ControlKey | blink::WebInputEvent::IsLeft, 33 EXPECT_EQ(blink::WebInputEvent::ControlKey | blink::WebInputEvent::IsLeft,
34 webkit_event.modifiers); 34 webkit_event.modifiers);
35 EXPECT_EQ(static_cast<int>(ui::DomCode::CONTROL_LEFT),
36 webkit_event.domCode);
35 } 37 }
36 { 38 {
37 // Release Ctrl. 39 // Release Ctrl.
38 ui::KeyEvent event(ui::ET_KEY_RELEASED, ui::VKEY_CONTROL, 40 ui::KeyEvent event(ui::ET_KEY_RELEASED, ui::VKEY_CONTROL,
39 ui::DomCode::CONTROL_LEFT, ui::EF_NONE); 41 ui::DomCode::CONTROL_LEFT, ui::EF_NONE);
40 blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event); 42 blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event);
41 // However, modifier bit for Control in |webkit_event| shouldn't be set. 43 // However, modifier bit for Control in |webkit_event| shouldn't be set.
42 EXPECT_EQ(blink::WebInputEvent::IsLeft, webkit_event.modifiers); 44 EXPECT_EQ(blink::WebInputEvent::IsLeft, webkit_event.modifiers);
45 EXPECT_EQ(static_cast<int>(ui::DomCode::CONTROL_LEFT),
46 webkit_event.domCode);
43 } 47 }
44 #if defined(USE_X11) 48 #if defined(USE_X11)
45 const int kLocationModifiers = 49 const int kLocationModifiers =
46 blink::WebInputEvent::IsLeft | blink::WebInputEvent::IsRight; 50 blink::WebInputEvent::IsLeft | blink::WebInputEvent::IsRight;
47 ui::ScopedXI2Event xev; 51 ui::ScopedXI2Event xev;
48 { 52 {
49 // Press Ctrl. 53 // Press Ctrl.
50 xev.InitKeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_CONTROL, 0); 54 xev.InitKeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_CONTROL, 0);
51 ui::KeyEvent event(xev); 55 ui::KeyEvent event(xev);
52 blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event); 56 blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event);
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 << "{dom_code:" 219 << "{dom_code:"
216 << ui::KeycodeConverter::DomCodeToCodeString(test_case.dom_code) 220 << ui::KeycodeConverter::DomCodeToCodeString(test_case.dom_code)
217 << ", ui_keycode:" << test_case.ui_keycode 221 << ", ui_keycode:" << test_case.ui_keycode
218 << ", x_keysym:" << test_case.x_keysym 222 << ", x_keysym:" << test_case.x_keysym
219 << "}, expect: " << test_case.expected_result; 223 << "}, expect: " << test_case.expected_result;
220 } 224 }
221 #endif 225 #endif
222 } 226 }
223 227
224 } // namespace content 228 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/web_input_event_aura.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698