Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 11478019: Revert 171681 (Closed)

Created:
8 years ago by tzik
Modified:
8 years ago
Reviewers:
Dale Curtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Revert 171681 > Delay delivery of audio input data. > > The AudioQueue API may use a large internal buffer and repeatedly call us > back to back once that internal buffer is filled. When this happens the > renderer client does not have enough time to read data back from the > shared memory before the next write comes along. If HandleInputBuffer() > is called too frequently, Sleep() to simulate realtime input and ensure > the shared memory doesn't get trampled. > > BUG=157613 > TEST=Playback works on older style Mac units. > > Review URL: https://codereview.chromium.org/11482002 TBR=dalecurtis@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171692

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M media/audio/mac/audio_input_mac.h View 3 chunks +1 line, -4 lines 0 comments Download
M media/audio/mac/audio_input_mac.cc View 1 chunk +1 line, -20 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tzik
8 years ago (2012-12-07 04:43:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698