Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 11482002: Delay delivery of audio input data. (Closed)

Created:
8 years ago by DaleCurtis
Modified:
8 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Delay delivery of audio input data. The AudioQueue API may use a large internal buffer and repeatedly call us back to back once that internal buffer is filled. When this happens the renderer client does not have enough time to read data back from the shared memory before the next write comes along. If HandleInputBuffer() is called too frequently, Sleep() to simulate realtime input and ensure the shared memory doesn't get trampled. BUG=157613 TEST=Playback works on older style Mac units. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171681 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171701

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add comment. #

Patch Set 3 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M media/audio/audio_input_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/mac/audio_input_mac.h View 3 chunks +4 lines, -1 line 0 comments Download
M media/audio/mac/audio_input_mac.cc View 1 1 chunk +20 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
DaleCurtis
Chris, WDYT? We need this for the pepper input fix. I don't know anything about ...
8 years ago (2012-12-06 21:48:44 UTC) #1
Chris Rogers
https://codereview.chromium.org/11482002/diff/1/media/audio/mac/audio_input_mac.cc File media/audio/mac/audio_input_mac.cc (right): https://codereview.chromium.org/11482002/diff/1/media/audio/mac/audio_input_mac.cc#newcode207 media/audio/mac/audio_input_mac.cc:207: base::PlatformThread::Sleep(buffer_length - elapsed); As we discussed in offline, this ...
8 years ago (2012-12-06 23:19:55 UTC) #2
DaleCurtis
https://codereview.chromium.org/11482002/diff/1/media/audio/mac/audio_input_mac.cc File media/audio/mac/audio_input_mac.cc (right): https://codereview.chromium.org/11482002/diff/1/media/audio/mac/audio_input_mac.cc#newcode207 media/audio/mac/audio_input_mac.cc:207: base::PlatformThread::Sleep(buffer_length - elapsed); On 2012/12/06 23:19:55, Chris Rogers wrote: ...
8 years ago (2012-12-06 23:41:07 UTC) #3
DaleCurtis
scherkus: Please owners review.
8 years ago (2012-12-06 23:46:29 UTC) #4
Chris Rogers
lgtm - I'm sure you'll keep a close eye on this one. And hopefully we ...
8 years ago (2012-12-06 23:47:23 UTC) #5
scherkus (not reviewing)
8 years ago (2012-12-07 00:30:36 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698