media/formats/mp4/box_reader.h - Issue 1147453002: MSE: Increase log visibility when unfragmented MP4 causes parse failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp4/box_reader.h

Issue 1147453002: MSE: Increase log visibility when unfragmented MP4 causes parse failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and addressed chcunningham's PS1 comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/formats/mp4/box_reader.h

diff --git a/media/formats/mp4/box_reader.h b/media/formats/mp4/box_reader.h

index 3360204ed5424a05d0a552633dfc076e22e2f713..6b59361612459d84e29448c3b19b43595ab98cce 100644

--- a/media/formats/mp4/box_reader.h

+++ b/media/formats/mp4/box_reader.h

@@ -22,7 +22,10 @@ class BoxReader;

struct MEDIA_EXPORT Box {

virtual ~Box();

+ // Parse errors may be logged using the BoxReader's log callback.

virtual bool Parse(BoxReader* reader) = 0;

virtual FourCC BoxType() const = 0;

};

« media/formats/mp4/box_definitions.h ('K') | « media/formats/mp4/box_definitions.cc ('k') | media/formats/mp4/box_reader.cc » ('j') | media/formats/mp4/rcheck.h » ('J')