Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: media/formats/mp4/box_reader.cc

Issue 1147453002: MSE: Increase log visibility when unfragmented MP4 causes parse failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased and addressed chcunningham's PS1 comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mp4/box_reader.cc
diff --git a/media/formats/mp4/box_reader.cc b/media/formats/mp4/box_reader.cc
index edebddd1a7fd180c45df3fabe52a1843f26e38d2..5105726da5d23ba2dddfbbc0469f2bacfd156b73 100644
--- a/media/formats/mp4/box_reader.cc
+++ b/media/formats/mp4/box_reader.cc
@@ -219,7 +219,8 @@ bool BoxReader::ReadHeader(bool* err) {
CHECK(Read4Into8(&size) && ReadFourCC(&type_));
if (size == 0) {
- // Media Source specific: we do not support boxes that run to EOS.
+ MEDIA_LOG(DEBUG, log_cb_) << "Media Source Extensions do not support ISO "
+ "BMFF boxes that run to EOS";
*err = true;
return false;
} else if (size == 1) {

Powered by Google App Engine
This is Rietveld 408576698