media/formats/mp4/box_definitions.h - Issue 1147453002: MSE: Increase log visibility when unfragmented MP4 causes parse failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp4/box_definitions.h

Issue 1147453002: MSE: Increase log visibility when unfragmented MP4 causes parse failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and addressed chcunningham's PS1 comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/formats/mp4/box_definitions.h

diff --git a/media/formats/mp4/box_definitions.h b/media/formats/mp4/box_definitions.h

index 127140368985bfc83af94c556df7363a984dfce4..026effe6b5fbd3fe036e63426400c03f288802a5 100644

--- a/media/formats/mp4/box_definitions.h

+++ b/media/formats/mp4/box_definitions.h

@@ -11,6 +11,7 @@

#include "base/basictypes.h"

#include "base/compiler_specific.h"

#include "media/base/media_export.h"

+#include "media/base/media_log.h"

DaleCurtis 2015/05/15 18:59:16 Is this necessary?

wolenetz 2015/05/15 19:02:27 Only for style. LogCB was previously used, below,

#include "media/formats/mp4/aac.h"

#include "media/formats/mp4/avc.h"

#include "media/formats/mp4/box_reader.h"

« no previous file with comments | « no previous file | media/formats/mp4/box_definitions.cc » ('j') | media/formats/mp4/rcheck.h » ('J')