Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1147433002: IndexedDB: Added IDBIndex.getAll() implementation. (Closed)

Created:
5 years, 7 months ago by cmumford
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez, jsbell
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Added IDBIndex.getAll() implementation. This is the experimental IDBIndex.getAll implementation for retrieving multiple values in a single request as proposed in https://www.w3.org/2008/webapps/wiki/IndexedDatabaseFeatures Mozilla's documentation for IDBIndex.getAll is at: https://developer.mozilla.org/en-US/docs/Web/API/IDBIndex/getAll In order to use run Chrome with: --enable-experimental-web-platform-features BUG=457450 Committed: https://crrev.com/75696ff695438f938582ffee66c705015d4249bb Cr-Commit-Position: refs/heads/master@{#330631}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tweaked getAll comments in indexed_db_database.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -11 lines) Patch
M content/browser/indexed_db/indexed_db_database.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 4 chunks +16 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
cmumford
5 years, 7 months ago (2015-05-14 20:49:49 UTC) #2
cmumford
Oh - just remembered. I also want to add a corruption test for IDBIndex.getAll(). Another ...
5 years, 7 months ago (2015-05-14 20:52:23 UTC) #3
cmumford
A corruption test depends on changes in https://codereview.chromium.org/1116253003, so I will followup this CL with ...
5 years, 7 months ago (2015-05-14 21:18:51 UTC) #4
jsbell
lgtm, will need tsepez@ to approve the messaging change. https://codereview.chromium.org/1147433002/diff/1/content/browser/indexed_db/indexed_db_database.cc File content/browser/indexed_db/indexed_db_database.cc (right): https://codereview.chromium.org/1147433002/diff/1/content/browser/indexed_db/indexed_db_database.cc#newcode764 content/browser/indexed_db/indexed_db_database.cc:764: ...
5 years, 7 months ago (2015-05-14 22:22:50 UTC) #5
cmumford
+tsepez to review content/common/indexed_db/indexed_db_messages.h https://codereview.chromium.org/1147433002/diff/1/content/browser/indexed_db/indexed_db_database.cc File content/browser/indexed_db/indexed_db_database.cc (right): https://codereview.chromium.org/1147433002/diff/1/content/browser/indexed_db/indexed_db_database.cc#newcode764 content/browser/indexed_db/indexed_db_database.cc:764: // ObjectStore Retrieval Operation On ...
5 years, 7 months ago (2015-05-15 20:55:08 UTC) #7
Tom Sepez
Messages LGTM
5 years, 7 months ago (2015-05-15 21:00:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147433002/20001
5 years, 7 months ago (2015-05-19 21:28:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 22:22:11 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:23:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75696ff695438f938582ffee66c705015d4249bb
Cr-Commit-Position: refs/heads/master@{#330631}

Powered by Google App Engine
This is Rietveld 408576698