Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: content/child/indexed_db/webidbdatabase_impl.cc

Issue 1147433002: IndexedDB: Added IDBIndex.getAll() implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweaked getAll comments in indexed_db_database.cc Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/indexed_db/indexed_db_dispatcher.cc ('k') | content/common/indexed_db/indexed_db_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/indexed_db/webidbdatabase_impl.cc
diff --git a/content/child/indexed_db/webidbdatabase_impl.cc b/content/child/indexed_db/webidbdatabase_impl.cc
index 81ce98a5822f672910b6cde077aae557c6f3923f..0d3d9893a473049cea1d5e3d76afa0e0e2e92913 100644
--- a/content/child/indexed_db/webidbdatabase_impl.cc
+++ b/content/child/indexed_db/webidbdatabase_impl.cc
@@ -122,15 +122,13 @@ void WebIDBDatabaseImpl::getAll(long long transaction_id,
long long max_count,
bool key_only,
WebIDBCallbacks* callbacks) {
- // TODO(cmumford): Remove DCHECK's for index_id/key_only once IDBIndex.getAll
- // is implemented.
- static const int64 kInvalidId = -1;
- DCHECK_EQ(kInvalidId, index_id);
+ // TODO(cmumford): Remove DCHECK for key_only once IDBIndex.getAllKeys is
+ // implemented.
DCHECK(!key_only);
IndexedDBDispatcher* dispatcher =
IndexedDBDispatcher::ThreadSpecificInstance(thread_safe_sender_.get());
dispatcher->RequestIDBDatabaseGetAll(
- ipc_database_id_, transaction_id, object_store_id,
+ ipc_database_id_, transaction_id, object_store_id, index_id,
IndexedDBKeyRangeBuilder::Build(key_range), max_count, callbacks);
}
« no previous file with comments | « content/child/indexed_db/indexed_db_dispatcher.cc ('k') | content/common/indexed_db/indexed_db_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698