Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1116253003: IndexedDB: Added IDBObjectStore.getAll() corruption test. (Closed)

Created:
5 years, 7 months ago by cmumford
Modified:
5 years, 6 months ago
Reviewers:
jsbell
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@idb-objectstore-getall
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Added IDBObjectStore.getAll() corruption test. This test would have been part of http://crrev.com/1074493002, but incorrect error handling in IndexedDBBackingStore prevented this test from passing. Test was failing because ObjectStoreCursorImpl::LoadCurrentRow() called IndexedDBBackingStore::Transaction::GetBlobInfoForRecord(), but didn't pass up its leveldb::Status making it indistinguishable from having a stale index - so the caller to IndexedDBBackingStore::Cursor::Continue didn't know that a "real" error occurred. BUG=457450 Committed: https://crrev.com/5d76fdd16ea4a35ebbe08027107676c20b3a0957 Cr-Commit-Position: refs/heads/master@{#332435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -25 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 19 chunks +36 lines, -23 lines 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 2 chunks +9 lines, -1 line 0 comments Download
M content/test/data/indexeddb/corrupted_open_db_detection.html View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jsbell
lgtm
5 years, 7 months ago (2015-05-04 23:39:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116253003/1
5 years, 7 months ago (2015-05-15 21:42:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/18675)
5 years, 7 months ago (2015-05-15 22:39:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116253003/1
5 years, 7 months ago (2015-05-19 19:06:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/90490)
5 years, 7 months ago (2015-05-19 20:18:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116253003/1
5 years, 6 months ago (2015-06-02 17:05:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 18:41:05 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 18:42:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d76fdd16ea4a35ebbe08027107676c20b3a0957
Cr-Commit-Position: refs/heads/master@{#332435}

Powered by Google App Engine
This is Rietveld 408576698