Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1147343003: Drop fillRule state from GraphicsContext (Closed)

Created:
5 years, 6 months ago by fs
Modified:
5 years, 6 months ago
Reviewers:
f(malita)
CC:
blink-reviews, krit, pdr+graphicswatchlist_chromium.org, dshwang, jbroman, slimming-paint-reviews_chromium.org, danakj, Rik, f(malita), Justin Novosad, blink-reviews-paint_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop fillRule state from GraphicsContext There was only a few trivial (local) uses of this state field left. Since the same state is carried in the Path (SkPath) object itself, make use of that instead. BUG=424655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196340

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -31 lines) Patch
M Source/core/paint/BoxBorderPainter.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/paint/ObjectPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 3 chunks +5 lines, -19 lines 0 comments Download
M Source/platform/graphics/GraphicsContextState.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/platform/graphics/GraphicsContextState.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fs
5 years, 6 months ago (2015-06-02 16:23:58 UTC) #2
f(malita)
lgtm
5 years, 6 months ago (2015-06-02 17:20:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147343003/20001
5 years, 6 months ago (2015-06-02 17:21:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64489)
5 years, 6 months ago (2015-06-02 18:35:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147343003/20001
5 years, 6 months ago (2015-06-02 18:44:08 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 19:56:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196340

Powered by Google App Engine
This is Rietveld 408576698