Reject constructor names that conflict with members.

Reject constructor names that conflict with members.

BUG=http://dartbug.com/3991

Committed: https://code.google.com/p/dart/source/detail?r=15894

[ngeoffray, 2012-12-08 13:53:32]

https://codereview.chromium.org/11472022/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
(right):

https://codereview.chromium.org/11472022/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:505: //
mechanism for duplicate members.
What makes it difficult to implement this today?

https://codereview.chromium.org/11472022/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:507: void
checkConstructorNameHack(ClassElement holder, FunctionElement member) {
assert that member.getEnclosingClass() == holder?

https://codereview.chromium.org/11472022/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:515: //
If the name could not be deconstructed, this is is from a
is is from a ... -> is a ...

https://codereview.chromium.org/11472022/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:521:
compiler.onDeprecatedFeature(member, 'conflicting constructor');
Something looks strange. Why are you implementing this check if it's deprecated?

[ahe, 2012-12-08 14:15:46]

This CL will give people a warning if they have a constructor whose name
conflicts with a regular member.

By using the onDeprecatedFeature, developers get a warning that can be turned
into a compile-time error.

[ngeoffray, 2012-12-08 14:27:23]

On 2012/12/08 14:15:46, ahe wrote:
> This CL will give people a warning if they have a constructor whose name
> conflicts with a regular member.

But as you said isn't that deprecated now? Why implementing it if we are going
to remove it soon?

> 
> By using the onDeprecatedFeature, developers get a warning that can be turned
> into a compile-time error.

[ngeoffray, 2012-12-09 10:17:49]

Took me quite some time to get it, but now I do :) LGTM!