Reject constructor names that conflict with members.

dart/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of scanner;
 
 class ClassElementParser extends PartialParser {
   ClassElementParser(Listener listener) : super(listener);
 
   Token parseClassBody(Token token) => fullParseClassBody(token);
@@ skipping 87 matching lines @@
       assert(identical(receiver.source.stringValue, 'operator'));
       // TODO(ahe): It is a hack to compare to ')', but it beats
       // parsing the node.
       bool isUnary = identical(operator.token.next.next.stringValue, ')');
       return Elements.constructOperatorName(operator.source, isUnary);
     } else {
       if (receiver == null) {
         listener.cancel('library prefix in named factory constructor not '
                         'implemented', node: send.receiver);
       }
+      if (receiver.source != enclosingElement.name) {
+        listener.onDeprecatedFeature(receiver, 'interface factories');
+      }
       return Elements.constructConstructorName(receiver.source,
                                                selector.source);
     }
   }
 
   void endMethod(Token getOrSet, Token beginToken, Token endToken) {
     super.endMethod(getOrSet, beginToken, endToken);
     FunctionExpression method = popNode();
     pushNode(null);
     bool isConstructor = isConstructorName(method.name);
@@ skipping 12 matching lines @@
         new PartialFunctionElement(name, beginToken, getOrSet, endToken,
                                    kind, method.modifiers, enclosingElement);
     addMember(memberElement);
   }
 
   void endFactoryMethod(Token beginToken, Token endToken) {
     super.endFactoryMethod(beginToken, endToken);
     FunctionExpression method = popNode();
     pushNode(null);
     SourceString name = getMethodNameHack(method.name);
+    Identifier singleIdentifierName = method.name.asIdentifier();
+    if (singleIdentifierName != null && singleIdentifierName.source == name) {
+      if (name != enclosingElement.name) {
+        listener.onDeprecatedFeature(method.name, 'interface factories');
+      }
+    }
     ElementKind kind = ElementKind.FUNCTION;
     Element memberElement =
         new PartialFunctionElement(name, beginToken, null, endToken,
                                    kind, method.modifiers, enclosingElement);
     addMember(memberElement);
   }
 
   void endFields(int count, Token beginToken, Token endToken) {
     super.endFields(count, beginToken, endToken);
     VariableDefinitions variableDefinitions = popNode();
@@ skipping 29 matching lines @@
 
   void endMetadata(Token beginToken, Token periodBeforeName, Token endToken) {
     popNode(); // Discard arguments.
     if (periodBeforeName != null) {
       popNode(); // Discard name.
     }
     popNode(); // Discard node (Send or Identifier).
     pushMetadata(new PartialMetadataAnnotation(beginToken));
   }
 }