Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2039)

Unified Diff: lib/runtime/dart/convert.js

Issue 1147143007: fixes #206, add checking for unary ops (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/runtime/dart/convert.js
diff --git a/lib/runtime/dart/convert.js b/lib/runtime/dart/convert.js
index 4ff12edfdb7645f2f13511ca154430a124f0429c..5721a75a96889e63431d22be5d8fb66f97aed2f7 100644
--- a/lib/runtime/dart/convert.js
+++ b/lib/runtime/dart/convert.js
@@ -1204,7 +1204,7 @@ var collection = dart.import(collection);
}
writeJsonValue(object) {
if (dart.is(object, core.num)) {
- if (dart.dsend(dart.dload(object, 'isFinite'), '!'))
+ if (!dart.notNull(dart.as(dart.dload(object, 'isFinite'), core.bool)))
Jennifer Messerly 2015/06/04 00:16:23 we'll probably want to do something about the nonN
return false;
this.writeNumber(dart.as(object, core.num));
return true;

Powered by Google App Engine
This is Rietveld 408576698