Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: lib/runtime/dart/_isolate_helper.js

Issue 1147143007: fixes #206, add checking for unary ops (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/runtime/dart/_js_helper.js » ('j') | lib/runtime/dart/convert.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_isolate_helper.js
diff --git a/lib/runtime/dart/_isolate_helper.js b/lib/runtime/dart/_isolate_helper.js
index 14722e3181c4603cb15f0fe68a5e018dec8ac9cb..35e5763118fc0363f22360810b54eccde7ef831b 100644
--- a/lib/runtime/dart/_isolate_helper.js
+++ b/lib/runtime/dart/_isolate_helper.js
@@ -589,7 +589,7 @@ var async = dart.import(async);
if (this.doneHandlers == null) {
this.doneHandlers = [];
}
- if (dart.dsend(this.doneHandlers, 'contains', responsePort))
+ if (dart.as(dart.dsend(this.doneHandlers, 'contains', responsePort), core.bool))
vsm 2015/06/04 17:07:32 We'll need a null check here as well.
Jennifer Messerly 2015/06/04 21:54:18 Done.
return;
dart.dsend(this.doneHandlers, 'add', responsePort);
}
@@ -689,7 +689,7 @@ var async = dart.import(async);
if (old != null)
old[_setGlobals]();
if (this[_scheduledControlEvents] != null) {
- while (dart.dload(this[_scheduledControlEvents], 'isNotEmpty')) {
+ while (dart.as(dart.dload(this[_scheduledControlEvents], 'isNotEmpty'), core.bool)) {
dart.dcall(dart.dsend(this[_scheduledControlEvents], 'removeFirst'));
}
}
« no previous file with comments | « no previous file | lib/runtime/dart/_js_helper.js » ('j') | lib/runtime/dart/convert.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698