Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/runtime/dart/async.js

Issue 1147143007: fixes #206, add checking for unary ops (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/runtime/dart/_isolate_helper.js ('K') | « lib/runtime/dart/_js_helper.js ('k') | lib/runtime/dart/convert.js » ('j') | lib/runtime/dart/convert.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/async.js
diff --git a/lib/runtime/dart/async.js b/lib/runtime/dart/async.js
index f085ffee4a44a1eda1f6f94315e07f3a3e583184..344a65a4085da9c68b12739241b01ba058fa8503 100644
--- a/lib/runtime/dart/async.js
+++ b/lib/runtime/dart/async.js
@@ -1396,7 +1396,7 @@ var collection = dart.import(collection);
if (core.identical(subscription[_next], subscription))
return null;
dart.assert(!dart.notNull(core.identical(subscription[_next], subscription)));
- if (subscription[_isFiring]) {
+ if (dart.as(subscription[_isFiring], core.bool)) {
dart.dcall(subscription[_setRemoveAfterFiring]);
} else {
dart.assert(!dart.notNull(core.identical(subscription[_next], subscription)));
« lib/runtime/dart/_isolate_helper.js ('K') | « lib/runtime/dart/_js_helper.js ('k') | lib/runtime/dart/convert.js » ('j') | lib/runtime/dart/convert.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698