Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1146733002: Revert of Reapply "Resolve references to "this" the same way as normal variables"" (Closed)

Created:
5 years, 7 months ago by wingo
Modified:
5 years, 7 months ago
Reviewers:
rossberg, Yang
CC:
v8-dev, Yang, dstence, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reapply "Resolve references to "this" the same way as normal variables"" (patchset #2 id:20001 of https://codereview.chromium.org/1136883006/) Reason for revert: Something is deserializing "this" declarations as Variable::NORMAL and not Variable::THIS https://codereview.chromium.org/1136123010/ Original issue's description: > Reapply "Resolve references to "this" the same way as normal variables"" > > This reapplies https://codereview.chromium.org/1136073002, along with > the followups: > > Remove Scope::scope_uses_this_ flag > https://codereview.chromium.org/1128963005 > > and > > PPC: Resolve references to "this" the same way as normal variables > https://codereview.chromium.org/1134073003 > > R=yangguo@chromium.org, rossberg@chromium.org > LOG=N > BUG= > > Committed: https://crrev.com/1efc1e4f7a3d30d5225e9d5cb2585cad7cb17099 > Cr-Commit-Position: refs/heads/master@{#28458} TBR=rossberg@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/24768fe200267e8feb12bc4a1247d5820b5d881b Cr-Commit-Position: refs/heads/master@{#28473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -407 lines) Patch
M src/arm/full-codegen-arm.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 4 chunks +14 lines, -45 lines 0 comments Download
M src/contexts.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/parser.cc View 7 chunks +12 lines, -18 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/preparser.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 3 chunks +8 lines, -59 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 3 chunks +3 lines, -17 lines 0 comments Download
M src/scopeinfo.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/scopes.h View 7 chunks +13 lines, -20 lines 0 comments Download
M src/scopes.cc View 11 chunks +41 lines, -45 lines 0 comments Download
M src/variables.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-scopes.js View 1 chunk +0 lines, -4 lines 0 comments Download
D test/mjsunit/harmony/arrow-functions-this.js View 1 chunk +0 lines, -81 lines 0 comments Download
M test/mjsunit/testcfg.py View 2 chunks +1 line, -2 lines 0 comments Download
D test/mjsunit/this-dynamic-lookup.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
Created Revert of Reapply "Resolve references to "this" the same way as normal variables""
5 years, 7 months ago (2015-05-19 10:57:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146733002/1
5 years, 7 months ago (2015-05-19 10:57:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 10:58:08 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 10:58:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24768fe200267e8feb12bc4a1247d5820b5d881b
Cr-Commit-Position: refs/heads/master@{#28473}

Powered by Google App Engine
This is Rietveld 408576698