Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1146303007: Fix use of 'sysroot' variable in harfbuzz.gyp (Closed)

Created:
5 years, 6 months ago by Sam Clegg
Modified:
5 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cbentzel+watch_chromium.org, matthewyuan, jonross
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use of 'sysroot' variable in harfbuzz.gyp The sysroot variable is set conditionally in common.gypi but not at the nesting level required for other conditional to depend on it like the one in hardbuzz does. This means that sysroot always appeared to be empty to harfbuzz.gyp, and hence the special handling for ARM linux was required. This change moves the setting of 'sysroot' up one level of nesting and defines 'pkg-config' in common.gypi so it can be shared. This is the third attempt at a landing. First attempt was reverted: https://codereview.chromium.org/1151753002 This is a re-land of the second attempt which was reverted speculatively (wrongly as it turned out): https://codereview.chromium.org/1158283003 TBR=cpu Committed: https://crrev.com/dea1c634b5328b1e171ba22698fb7027f338453f Cr-Commit-Position: refs/heads/master@{#332982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -93 lines) Patch
M build/common.gypi View 8 chunks +34 lines, -28 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/harfbuzz-ng/harfbuzz.gyp View 2 chunks +0 lines, -18 lines 0 comments Download
M third_party/libexif/libexif.gyp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sam Clegg
5 years, 6 months ago (2015-06-04 22:26:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146303007/1
5 years, 6 months ago (2015-06-05 01:08:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 01:13:49 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 01:14:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dea1c634b5328b1e171ba22698fb7027f338453f
Cr-Commit-Position: refs/heads/master@{#332982}

Powered by Google App Engine
This is Rietveld 408576698