Fix use of 'sysroot' variable in harfbuzz.gyp

Fix use of 'sysroot' variable in harfbuzz.gyp

The sysroot variable is set conditionally in common.gypi
but not at the nesting level required for other conditional
to depend on it like the one in hardbuzz does.  This means
that sysroot always appeared to be empty to harfbuzz.gyp,
and hence the special handling for ARM linux was required.

This change moves the setting of 'sysroot' up one level of
nesting and defines 'pkg-config' in common.gypi so it can
be shared.

Committed: https://crrev.com/6a80b32f309490f44347f2925589a6f0fc23c3ff
Cr-Commit-Position: refs/heads/master@{#331506}

[Sam Clegg, 2015-05-22 17:39:00]

sbc@chromium.org changed reviewers:
+ mazda@chromium.org

[Sam Clegg, 2015-05-22 17:41:12]

sbc@chromium.org changed reviewers:
+ dpranke@chromium.org

[Sam Clegg, 2015-05-22 17:43:01]

sbc@chromium.org changed reviewers:
+ jshin@chromium.org

[Sam Clegg, 2015-05-22 17:44:42]

sbc@chromium.org changed reviewers:
- jshin@chromium.org

[Sam Clegg, 2015-05-22 20:21:27]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-22 20:22:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151753002/60001

[commit-bot: I haz the power, 2015-05-22 21:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-22 21:34:01]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-05-22 22:08:59]

lgtm

[Sam Clegg, 2015-05-22 22:16:32]

+cpu for top level OWNERS

[Sam Clegg, 2015-05-22 23:58:33]

sbc@chromium.org changed reviewers:
+ cpu@chromium.org

[Sam Clegg, 2015-05-22 23:58:34]

+cpu for top level OWNERS

[cpu_(ooo_6.6-7.5), 2015-05-26 17:45:32]

lgtm

[Sam Clegg, 2015-05-26 17:45:53]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-05-26 17:46:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151753002/60001

[commit-bot: I haz the power, 2015-05-26 17:53:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-26 17:53:44]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sam Clegg, 2015-05-26 17:58:47]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-05-26 17:58:48]

The patchset sent to the CQ was uploaded after l-g-t-m from cpu@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1151753002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-05-26 18:00:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151753002/100001

[commit-bot: I haz the power, 2015-05-27 00:02:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-27 00:02:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Sam Clegg, 2015-05-27 00:17:14]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-05-27 00:18:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151753002/100001

[commit-bot: I haz the power, 2015-05-27 01:23:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-05-27 01:25:12]

Patchset 6 (id:??) landed as
https://crrev.com/6a80b32f309490f44347f2925589a6f0fc23c3ff
Cr-Commit-Position: refs/heads/master@{#331506}

[spang, 2015-05-27 20:40:30]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1154213004/ by spang@chromium.org.

The reason for reverting is: Breaks GYP for Chrome OS builds. Repro steps:

 cros chrome-sdk --board=amd64-generic
 gclient runhooks

Updating projects from gyp files...
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --libs-only-l nss | sed
-e "s/-lssl3//"' returned exit status 0.
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --libs libcras' returned
exit status 127.
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --cflags x11' returned
exit status 127.
Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit
status 1 in /ssd/src/chromium

TEST=cros chrome-sdk --board=amd64-generic && gclient runhooks.