Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1145223002: MIPS: Add float instructions and test coverage, part two (Closed)

Created:
5 years, 7 months ago by Djordje.Pesic
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Add float instructions and test coverage, part two Implement assembler, disassembler tests for all instructions for mips32 and mips64. Additionally, add missing single precision float instructions for r2 and r6 architecture variants in assembler, simulator and disassembler with corresponding tests. Committed: https://crrev.com/874c54e05e92e04590b1026b495108abfd6063b7 Cr-Commit-Position: refs/heads/master@{#28595}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3661 lines, -77 lines) Patch
M src/mips/assembler-mips.h View 4 chunks +8 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 6 chunks +43 lines, -1 line 0 comments Download
M src/mips/constants-mips.h View 7 chunks +25 lines, -12 lines 0 comments Download
M src/mips/constants-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/disasm-mips.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.h View 3 chunks +9 lines, -2 lines 0 comments Download
M src/mips/simulator-mips.cc View 17 chunks +434 lines, -12 lines 0 comments Download
M src/mips64/assembler-mips64.h View 4 chunks +9 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 4 chunks +47 lines, -0 lines 0 comments Download
M src/mips64/constants-mips64.h View 7 chunks +28 lines, -12 lines 0 comments Download
M src/mips64/constants-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M src/mips64/simulator-mips64.h View 3 chunks +7 lines, -2 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 17 chunks +411 lines, -12 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 5 chunks +1186 lines, -24 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 chunk +1162 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 2 chunks +126 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 2 chunks +129 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dusmil.imgtec
https://codereview.chromium.org/1145223002/diff/1/test/cctest/test-disasm-mips.cc File test/cctest/test-disasm-mips.cc (right): https://codereview.chromium.org/1145223002/diff/1/test/cctest/test-disasm-mips.cc#newcode635 test/cctest/test-disasm-mips.cc:635: if (kArchVariant == kMips32r6) { It should be IsMipsArchVariant() ...
5 years, 7 months ago (2015-05-22 11:03:37 UTC) #2
Djordje.Pesic
https://codereview.chromium.org/1145223002/diff/1/test/cctest/test-disasm-mips.cc File test/cctest/test-disasm-mips.cc (right): https://codereview.chromium.org/1145223002/diff/1/test/cctest/test-disasm-mips.cc#newcode635 test/cctest/test-disasm-mips.cc:635: if (kArchVariant == kMips32r6) { On 2015/05/22 11:03:37, dusmil.imgtec ...
5 years, 7 months ago (2015-05-22 11:46:35 UTC) #3
dusmil.imgtec
LGTM.
5 years, 7 months ago (2015-05-22 12:50:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145223002/20001
5 years, 7 months ago (2015-05-22 13:08:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-22 13:49:27 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/874c54e05e92e04590b1026b495108abfd6063b7 Cr-Commit-Position: refs/heads/master@{#28595}
5 years, 7 months ago (2015-05-22 13:49:39 UTC) #8
Paul.Lind_imgtec.com
5 years, 7 months ago (2015-05-22 13:49:50 UTC) #9
Message was sent while issue was closed.
I am out of the office from Friday May 22 through Monday June 1, 2015.

I will have occasional email access during this time. There may be a multiple
day delay in my response.

Thanks,

Paul

Powered by Google App Engine
This is Rietveld 408576698