Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1145103002: Take freed handles into account when scheduling idle GCs. (Closed)

Created:
5 years, 7 months ago by ulan
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Take freed handles into account when scheduling idle GCs. BUG= Committed: https://crrev.com/f2f8001f1b3df3e7f9492222b3f996af5e64d329 Cr-Commit-Position: refs/heads/master@{#28508}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M src/heap/gc-idle-time-handler.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 2 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 7 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL
5 years, 7 months ago (2015-05-20 11:18:20 UTC) #2
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1145103002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1145103002/diff/1/src/heap/heap.cc#newcode934 src/heap/heap.cc:934: gc_idle_time_handler_.NotifyMarkCompact(next_gc_likely_to_collect_more); Here it would also make sense to ...
5 years, 7 months ago (2015-05-20 11:39:13 UTC) #3
ulan
https://codereview.chromium.org/1145103002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1145103002/diff/1/src/heap/heap.cc#newcode934 src/heap/heap.cc:934: gc_idle_time_handler_.NotifyMarkCompact(next_gc_likely_to_collect_more); On 2015/05/20 11:39:13, Hannes Payer wrote: > Here ...
5 years, 7 months ago (2015-05-20 11:45:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145103002/1
5 years, 7 months ago (2015-05-20 11:45:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 12:10:16 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 12:10:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2f8001f1b3df3e7f9492222b3f996af5e64d329
Cr-Commit-Position: refs/heads/master@{#28508}

Powered by Google App Engine
This is Rietveld 408576698