Take freed handles into account when scheduling idle GCs.

test/unittests/heap/gc-idle-time-handler-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits>
 
 #include "src/heap/gc-idle-time-handler.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace v8 {
@@ skipping 49 matching lines @@
 
   void TransitionToDoneMode(const GCIdleTimeHandler::HeapState& heap_state,
                             double idle_time_ms,
                             GCIdleTimeActionType expected) {
     EXPECT_EQ(GCIdleTimeHandler::kReduceMemory, handler()->mode());
     int limit = GCIdleTimeHandler::kMaxIdleMarkCompacts;
     for (int i = 0; i < limit; i++) {
       GCIdleTimeAction action = handler()->Compute(idle_time_ms, heap_state);
       EXPECT_EQ(expected, action.type);
       EXPECT_TRUE(action.reduce_memory);
-      handler()->NotifyMarkCompact();
+      handler()->NotifyMarkCompact(true);
       handler()->NotifyIdleMarkCompact();
     }
     handler()->Compute(idle_time_ms, heap_state);
     EXPECT_EQ(GCIdleTimeHandler::kDone, handler()->mode());
   }
 
   void TransitionToReduceLatencyMode(
       const GCIdleTimeHandler::HeapState& heap_state) {
     EXPECT_EQ(GCIdleTimeHandler::kDone, handler()->mode());
     int limit = GCIdleTimeHandler::kMarkCompactsBeforeMutatorIsActive;
     double idle_time_ms = GCIdleTimeHandler::kMinLongIdleTime;
     for (int i = 0; i < limit; i++) {
       GCIdleTimeAction action = handler()->Compute(idle_time_ms, heap_state);
       EXPECT_EQ(DONE, action.type);
-      handler()->NotifyMarkCompact();
+      handler()->NotifyMarkCompact(true);
     }
     handler()->Compute(idle_time_ms, heap_state);
     EXPECT_EQ(GCIdleTimeHandler::kReduceLatency, handler()->mode());
   }
 
   static const size_t kSizeOfObjects = 100 * MB;
   static const size_t kMarkCompactSpeed = 200 * KB;
   static const size_t kMarkingSpeed = 200 * KB;
   static const size_t kScavengeSpeed = 100 * KB;
   static const size_t kNewSpaceCapacity = 1 * MB;
@@ skipping 359 matching lines @@
 
 TEST_F(GCIdleTimeHandlerTest, StopEventually1) {
   GCIdleTimeHandler::HeapState heap_state = DefaultHeapState();
   heap_state.incremental_marking_stopped = true;
   heap_state.can_start_incremental_marking = false;
   double idle_time_ms = GCIdleTimeHandler::kMinLongIdleTime;
   bool stopped = false;
   for (int i = 0; i < kMaxNotifications && !stopped; i++) {
     GCIdleTimeAction action = handler()->Compute(idle_time_ms, heap_state);
     if (action.type == DO_INCREMENTAL_MARKING || action.type == DO_FULL_GC) {
-      handler()->NotifyMarkCompact();
+      handler()->NotifyMarkCompact(true);
       handler()->NotifyIdleMarkCompact();
     }
     if (action.type == DONE) stopped = true;
   }
   EXPECT_TRUE(stopped);
 }
 
 
 TEST_F(GCIdleTimeHandlerTest, StopEventually2) {
   GCIdleTimeHandler::HeapState heap_state = DefaultHeapState();
@@ skipping 96 matching lines @@
 
 TEST_F(GCIdleTimeHandlerTest, StayInReduceLatencyModeBecauseOfMarkCompacts) {
   GCIdleTimeHandler::HeapState heap_state = DefaultHeapState();
   heap_state.incremental_marking_stopped = true;
   heap_state.can_start_incremental_marking = false;
   double idle_time_ms = GCIdleTimeHandler::kMinLongIdleTime;
   int limit = GCIdleTimeHandler::kLongIdleNotificationsBeforeMutatorIsIdle;
   for (int i = 0; i < kMaxNotifications; i++) {
     GCIdleTimeAction action = handler()->Compute(idle_time_ms, heap_state);
     EXPECT_TRUE(DO_NOTHING == action.type || DONE == action.type);
-    if ((i + 1) % limit == 0) handler()->NotifyMarkCompact();
+    if ((i + 1) % limit == 0) handler()->NotifyMarkCompact(true);
     EXPECT_EQ(GCIdleTimeHandler::kReduceLatency, handler()->mode());
   }
 }
 
 
 TEST_F(GCIdleTimeHandlerTest, ReduceMemoryToReduceLatency) {
   GCIdleTimeHandler::HeapState heap_state = DefaultHeapState();
   heap_state.incremental_marking_stopped = true;
   heap_state.can_start_incremental_marking = false;
   double idle_time_ms = GCIdleTimeHandler::kMinLongIdleTime;
   int limit = GCIdleTimeHandler::kMaxIdleMarkCompacts;
   for (int idle_gc = 0; idle_gc < limit; idle_gc++) {
     TransitionToReduceMemoryMode(heap_state);
     GCIdleTimeAction action = handler()->Compute(idle_time_ms, heap_state);
     EXPECT_EQ(DO_INCREMENTAL_MARKING, action.type);
     EXPECT_TRUE(action.reduce_memory);
     EXPECT_EQ(GCIdleTimeHandler::kReduceMemory, handler()->mode());
     for (int i = 0; i < idle_gc; i++) {
       action = handler()->Compute(idle_time_ms, heap_state);
       EXPECT_EQ(DO_INCREMENTAL_MARKING, action.type);
       EXPECT_TRUE(action.reduce_memory);
       // ReduceMemory mode should tolerate one mutator GC per idle GC.
       handler()->NotifyScavenge();
       // Notify idle GC.
-      handler()->NotifyMarkCompact();
+      handler()->NotifyMarkCompact(true);
       handler()->NotifyIdleMarkCompact();
     }
     // Transition to ReduceLatency mode after doing |idle_gc| idle GCs.
     handler()->NotifyScavenge();
     action = handler()->Compute(idle_time_ms, heap_state);
     EXPECT_EQ(DO_NOTHING, action.type);
     EXPECT_FALSE(action.reduce_memory);
     EXPECT_EQ(GCIdleTimeHandler::kReduceLatency, handler()->mode());
   }
 }
@@ skipping 10 matching lines @@
   EXPECT_EQ(DO_INCREMENTAL_MARKING, action.type);
   EXPECT_TRUE(action.reduce_memory);
   for (int i = 0; i < limit; i++) {
     action = handler()->Compute(idle_time_ms, heap_state);
     EXPECT_EQ(DO_INCREMENTAL_MARKING, action.type);
     EXPECT_TRUE(action.reduce_memory);
     EXPECT_EQ(GCIdleTimeHandler::kReduceMemory, handler()->mode());
     // ReduceMemory mode should tolerate one mutator GC per idle GC.
     handler()->NotifyScavenge();
     // Notify idle GC.
-    handler()->NotifyMarkCompact();
+    handler()->NotifyMarkCompact(true);
     handler()->NotifyIdleMarkCompact();
   }
   action = handler()->Compute(idle_time_ms, heap_state);
   EXPECT_EQ(DONE, action.type);
 }
 
 
 TEST_F(GCIdleTimeHandlerTest, DoneIfNotMakingProgressOnSweeping) {
   // Regression test for crbug.com/489323.
   GCIdleTimeHandler::HeapState heap_state = DefaultHeapState();
@@ skipping 42 matching lines @@
   int limit =
       GCIdleTimeHandler::kBackgroundIdleNotificationsBeforeMutatorIsIdle;
   for (int i = 0; i < limit; i++) {
     GCIdleTimeAction action = handler()->Compute(idle_time_ms, heap_state);
     EXPECT_EQ(DO_INCREMENTAL_MARKING, action.type);
   }
   handler()->Compute(idle_time_ms, heap_state);
   EXPECT_EQ(GCIdleTimeHandler::kReduceMemory, handler()->mode());
 }
 
+
+TEST_F(GCIdleTimeHandlerTest, SkipUselessGCs) {
+  GCIdleTimeHandler::HeapState heap_state = DefaultHeapState();
+  heap_state.incremental_marking_stopped = false;
+  heap_state.can_start_incremental_marking = true;
+  TransitionToReduceMemoryMode(heap_state);
+  EXPECT_EQ(GCIdleTimeHandler::kReduceMemory, handler()->mode());
+  double idle_time_ms = GCIdleTimeHandler::kMinLongIdleTime;
+  GCIdleTimeAction action = handler()->Compute(idle_time_ms, heap_state);
+  EXPECT_EQ(DO_INCREMENTAL_MARKING, action.type);
+  handler()->NotifyMarkCompact(false);
+  handler()->NotifyIdleMarkCompact();
+  action = handler()->Compute(idle_time_ms, heap_state);
+  EXPECT_EQ(DONE, action.type);
+}
+
 }  // namespace internal
 }  // namespace v8