Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: src/heap/heap.cc

Issue 1145103002: Take freed handles into account when scheduling idle GCs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/gc-idle-time-handler.cc ('k') | test/unittests/heap/gc-idle-time-handler-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/once.h" 10 #include "src/base/once.h"
(...skipping 913 matching lines...) Expand 10 before | Expand all | Expand 10 after
924 next_gc_likely_to_collect_more = 924 next_gc_likely_to_collect_more =
925 PerformGarbageCollection(collector, gc_callback_flags); 925 PerformGarbageCollection(collector, gc_callback_flags);
926 } 926 }
927 927
928 GarbageCollectionEpilogue(); 928 GarbageCollectionEpilogue();
929 if (collector == MARK_COMPACTOR && FLAG_track_detached_contexts) { 929 if (collector == MARK_COMPACTOR && FLAG_track_detached_contexts) {
930 isolate()->CheckDetachedContextsAfterGC(); 930 isolate()->CheckDetachedContextsAfterGC();
931 } 931 }
932 932
933 if (collector == MARK_COMPACTOR) { 933 if (collector == MARK_COMPACTOR) {
934 gc_idle_time_handler_.NotifyMarkCompact(); 934 gc_idle_time_handler_.NotifyMarkCompact(next_gc_likely_to_collect_more);
Hannes Payer (out of office) 2015/05/20 11:39:13 Here it would also make sense to take fragmentatio
ulan 2015/05/20 11:45:10 I wanted to add fragmentation check after landing
935 } else { 935 } else {
936 gc_idle_time_handler_.NotifyScavenge(); 936 gc_idle_time_handler_.NotifyScavenge();
937 } 937 }
938 938
939 tracer()->Stop(collector); 939 tracer()->Stop(collector);
940 } 940 }
941 941
942 if (collector == MARK_COMPACTOR && 942 if (collector == MARK_COMPACTOR &&
943 (gc_callback_flags & kGCCallbackFlagForced) != 0) { 943 (gc_callback_flags & kGCCallbackFlagForced) != 0) {
944 isolate()->CountUsage(v8::Isolate::kForcedGC); 944 isolate()->CountUsage(v8::Isolate::kForcedGC);
(...skipping 5596 matching lines...) Expand 10 before | Expand all | Expand 10 after
6541 *object_type = "CODE_TYPE"; \ 6541 *object_type = "CODE_TYPE"; \
6542 *object_sub_type = "CODE_AGE/" #name; \ 6542 *object_sub_type = "CODE_AGE/" #name; \
6543 return true; 6543 return true;
6544 CODE_AGE_LIST_COMPLETE(COMPARE_AND_RETURN_NAME) 6544 CODE_AGE_LIST_COMPLETE(COMPARE_AND_RETURN_NAME)
6545 #undef COMPARE_AND_RETURN_NAME 6545 #undef COMPARE_AND_RETURN_NAME
6546 } 6546 }
6547 return false; 6547 return false;
6548 } 6548 }
6549 } 6549 }
6550 } // namespace v8::internal 6550 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap/gc-idle-time-handler.cc ('k') | test/unittests/heap/gc-idle-time-handler-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698