Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1145093002: Add a runtime flag for the column-fill property. (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Add a runtime flag for the column-fill property. Decouple column-fill support from the RegionBasedColumns flag. The new multicol implementation is about to ship. All other multicol properties are -webkit- prefixed, except for column-fill. Allowing such a mix would very likely confuse authors, so better hide column-fill away until we can unprefix all other multicol properties. If column-fill isn't supported, the layout engine will behave as if it were set to 'auto', which means that a multicol container with a specified height won't have its columns balanced. Discussed here: https://groups.google.com/a/chromium.org/d/msg/blink-dev/hhecvWUBJvg/nq4X3s8Jmk4J R=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195873

Patch Set 1 #

Total comments: 8

Patch Set 2 : code review #

Total comments: 2

Patch Set 3 : Name the runtime flag ColumnFill after all, since that's all it's going to control #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M Source/core/css/CSSProperties.in View 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutMultiColumnSet.cpp View 1 2 2 chunks +11 lines, -2 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (3 generated)
mstensho (USE GERRIT)
5 years, 7 months ago (2015-05-20 12:39:23 UTC) #1
Julien - ping for review
I am concerned about the initial value change. FWIW I was on board with either ...
5 years, 7 months ago (2015-05-20 19:01:23 UTC) #3
mstensho (USE GERRIT)
No new patch, just comments. I want to settle this matter first. Should I: A: ...
5 years, 7 months ago (2015-05-20 19:30:42 UTC) #4
esprehn
https://codereview.chromium.org/1145093002/diff/1/Source/core/style/ComputedStyle.cpp File Source/core/style/ComputedStyle.cpp (right): https://codereview.chromium.org/1145093002/diff/1/Source/core/style/ComputedStyle.cpp#newcode1652 Source/core/style/ComputedStyle.cpp:1652: // implementation, which has no support for this property. ...
5 years, 7 months ago (2015-05-20 20:26:55 UTC) #5
mstensho (USE GERRIT)
Correction to my confusing alphabet soup comment: --- No new patch, just comments. I want ...
5 years, 7 months ago (2015-05-21 07:08:55 UTC) #6
Julien - ping for review
On 2015/05/20 at 19:30:42, mstensho wrote: > No new patch, just comments. I want to ...
5 years, 7 months ago (2015-05-21 14:12:15 UTC) #7
Julien - ping for review
https://codereview.chromium.org/1145093002/diff/1/Source/core/style/ComputedStyle.cpp File Source/core/style/ComputedStyle.cpp (right): https://codereview.chromium.org/1145093002/diff/1/Source/core/style/ComputedStyle.cpp#newcode1652 Source/core/style/ComputedStyle.cpp:1652: // implementation, which has no support for this property. ...
5 years, 7 months ago (2015-05-21 14:12:47 UTC) #8
mstensho (USE GERRIT)
On 2015/05/21 14:12:15, Julien Chaffraix - PST wrote: > On 2015/05/20 at 19:30:42, mstensho wrote: ...
5 years, 7 months ago (2015-05-21 18:47:41 UTC) #9
mstensho (USE GERRIT)
New patch. Please have another look.
5 years, 7 months ago (2015-05-22 08:06:41 UTC) #10
mstensho (USE GERRIT)
On 2015/05/22 08:06:41, mstensho wrote: > New patch. Please have another look. I'm not sure ...
5 years, 7 months ago (2015-05-22 13:38:53 UTC) #11
Julien - ping for review
On 2015/05/22 at 13:38:53, mstensho wrote: > On 2015/05/22 08:06:41, mstensho wrote: > > New ...
5 years, 7 months ago (2015-05-22 22:08:51 UTC) #12
Julien - ping for review
lgtm https://codereview.chromium.org/1145093002/diff/20001/Source/core/layout/LayoutMultiColumnSet.cpp File Source/core/layout/LayoutMultiColumnSet.cpp (right): https://codereview.chromium.org/1145093002/diff/20001/Source/core/layout/LayoutMultiColumnSet.cpp#newcode141 Source/core/layout/LayoutMultiColumnSet.cpp:141: if (RuntimeEnabledFeatures::unprefixMulticolEnabled()) { Comment about why we do ...
5 years, 7 months ago (2015-05-22 22:09:18 UTC) #13
mstensho (USE GERRIT)
Renamed the flag back to ColumnFill, and landing. https://codereview.chromium.org/1145093002/diff/20001/Source/core/layout/LayoutMultiColumnSet.cpp File Source/core/layout/LayoutMultiColumnSet.cpp (right): https://codereview.chromium.org/1145093002/diff/20001/Source/core/layout/LayoutMultiColumnSet.cpp#newcode141 Source/core/layout/LayoutMultiColumnSet.cpp:141: if ...
5 years, 6 months ago (2015-05-25 18:47:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145093002/40001
5 years, 6 months ago (2015-05-25 18:47:38 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-05-25 20:01:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195873

Powered by Google App Engine
This is Rietveld 408576698