Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1150313002: *** NOT FOR LANDING *** Unprefix multicol behind a flag (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)
Modified:
5 years, 7 months ago
Reviewers:
CC:
blink-reviews, shans, vivekg_samsung, dshwang, eae+blinkwatch, vivekg, apavlov+blink_chromium.org, rwlbuis, arv+blink, blink-reviews-css, szager+layoutwatch_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, Eric Willigers, rjwright, blink-reviews-style_chromium.org, zoltan1, darktears, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

*** NOT FOR LANDING *** Unprefix multicol behind a flag Try to unprefix multicol, depending on the UnprefixMulticol runtime flag. A lot of work is required to keep the unprefixed properties unexposed if the flag is disabled, though. Still not done. Regular parsing and getComputedStyle should work, but e.g. document.getElementById("foo").style.columnCount doesn't work as expected when the flag is disabled.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -132 lines) Patch
M Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 6 chunks +17 lines, -16 lines 0 comments Download
M Source/core/css/CSSProperties.in View 5 chunks +19 lines, -10 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 9 chunks +41 lines, -22 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 3 chunks +10 lines, -8 lines 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 4 chunks +1 line, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 6 chunks +37 lines, -13 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 3 chunks +19 lines, -10 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnSet.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/paint/BlockPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/MultiColumnSetPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/ComputedStyle.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698