Source/core/css/parser/CSSParserFastPaths.cpp - Issue 1145093002: Add a runtime flag for the column-fill property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserFastPaths.cpp

Issue 1145093002: Add a runtime flag for the column-fill property. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Name the runtime flag ColumnFill after all, since that's all it's going to control Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/Source/core/css/parser/CSSParserFastPaths.cpp b/Source/core/css/parser/CSSParserFastPaths.cpp

index 846fd07242611f240e33c64cd22ae262844bf3a8..396eefebe85ee14abd4230e61d1c7672839855af 100644

--- a/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -308,7 +308,7 @@ bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID propertyId

case CSSPropertyWebkitBoxPack:

return valueID == CSSValueStart || valueID == CSSValueEnd || valueID == CSSValueCenter || valueID == CSSValueJustify;

case CSSPropertyColumnFill:

- ASSERT(RuntimeEnabledFeatures::regionBasedColumnsEnabled());

+ ASSERT(RuntimeEnabledFeatures::columnFillEnabled());

return valueID == CSSValueAuto || valueID == CSSValueBalance;

case CSSPropertyAlignItems:

// FIXME: Per CSS alignment, this property should accept the same arguments as 'justify-self' so we should share its parsing code.