|
Revert of [Sync] Refactoring polling to be reliable. (patchset #5 id:80001 of https://codereview.chromium.org/1132013004/)
Reason for revert:
Failing on valgrind bots
Original issue's description:
> [Sync] Refactoring polling to be reliable.
>
> Polling is now an important component of sync health, as it can sometimes be
> the only time we'll query for certain datatypes. As such, the following
> has changed:
> - Polls that fail will be retried (with backoff).
> - As such, the logic to force a poll after an auth error isn't needed anymore
> - The last successful poll time will be persisted in the sync prefs.
> - On startup, schedule the first poll for last_poll_time + poll_interval
> (or Now(), whichever is latest).
> - Receiving a new poll interval from the server will update the poll timer
> - The poll timer is now a one shot timer, and only restarts on success
> - Some code cleanup to make the above more straightforward
>
> BUG= 482154
>
> Committed: https://crrev.com/3777d8727d7b4caedfb72bfdcbe2fea1f1d1d594
> Cr-Commit-Position: refs/heads/master@{#329669}
TBR=pavely@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 482154
Committed: https://crrev.com/938b3c001b85f2193151dda0ae659ba776d12e1f
Cr-Commit-Position: refs/heads/master@{#329683}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+488 lines, -649 lines) |
Patch |
 |
M |
chrome/browser/sync/glue/sync_backend_host_core.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_core.cc
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_impl.cc
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
components/sync_driver/pref_names.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/sync_driver/pref_names.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/sync_driver/sync_prefs.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/sync_driver/sync_prefs.cc
|
View
|
|
3 chunks |
+0 lines, -13 lines |
0 comments
|
Download
|
 |
M |
sync/engine/sync_scheduler.h
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
sync/engine/sync_scheduler_impl.h
|
View
|
|
4 chunks |
+13 lines, -9 lines |
0 comments
|
Download
|
 |
M |
sync/engine/sync_scheduler_impl.cc
|
View
|
|
17 chunks |
+94 lines, -109 lines |
0 comments
|
Download
|
 |
M |
sync/engine/sync_scheduler_unittest.cc
|
View
|
|
56 chunks |
+117 lines, -178 lines |
0 comments
|
Download
|
 |
M |
sync/engine/syncer.h
|
View
|
|
4 chunks |
+22 lines, -35 lines |
0 comments
|
Download
|
 |
M |
sync/engine/syncer.cc
|
View
|
|
5 chunks |
+2 lines, -16 lines |
0 comments
|
Download
|
 |
M |
sync/engine/syncer_unittest.cc
|
View
|
|
174 chunks |
+211 lines, -212 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/js_sync_manager_observer_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/sessions/sync_session_snapshot.h
|
View
|
|
3 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/sessions/sync_session_snapshot.cc
|
View
|
|
3 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/sessions/sync_session_snapshot_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/sync_manager.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/test/fake_sync_manager.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_manager_impl.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_manager_impl.cc
|
View
|
|
4 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_manager_impl_unittest.cc
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_rollback_manager.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_rollback_manager.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_rollback_manager_base.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_rollback_manager_base.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_rollback_manager_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/test/fake_sync_manager.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/sessions/status_controller.h
|
View
|
|
2 chunks |
+1 line, -13 lines |
0 comments
|
Download
|
 |
M |
sync/sessions/status_controller.cc
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
sync/sessions/sync_session.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/test/engine/fake_sync_scheduler.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/test/engine/fake_sync_scheduler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/tools/sync_client.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|