Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: components/sync_driver/sync_prefs.cc

Issue 1144443004: Revert of [Sync] Refactoring polling to be reliable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync_driver/sync_prefs.h ('k') | sync/engine/sync_scheduler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync_driver/sync_prefs.h" 5 #include "components/sync_driver/sync_prefs.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_member.h" 8 #include "base/prefs/pref_member.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 20 matching lines...) Expand all
31 SyncPrefs::SyncPrefs() : pref_service_(NULL) {} 31 SyncPrefs::SyncPrefs() : pref_service_(NULL) {}
32 32
33 SyncPrefs::~SyncPrefs() { DCHECK(CalledOnValidThread()); } 33 SyncPrefs::~SyncPrefs() { DCHECK(CalledOnValidThread()); }
34 34
35 // static 35 // static
36 void SyncPrefs::RegisterProfilePrefs( 36 void SyncPrefs::RegisterProfilePrefs(
37 user_prefs::PrefRegistrySyncable* registry) { 37 user_prefs::PrefRegistrySyncable* registry) {
38 registry->RegisterBooleanPref(prefs::kSyncHasSetupCompleted, false); 38 registry->RegisterBooleanPref(prefs::kSyncHasSetupCompleted, false);
39 registry->RegisterBooleanPref(prefs::kSyncSuppressStart, false); 39 registry->RegisterBooleanPref(prefs::kSyncSuppressStart, false);
40 registry->RegisterInt64Pref(prefs::kSyncLastSyncedTime, 0); 40 registry->RegisterInt64Pref(prefs::kSyncLastSyncedTime, 0);
41 registry->RegisterInt64Pref(prefs::kSyncLastPollTime, 0);
42 registry->RegisterInt64Pref(prefs::kSyncFirstSyncTime, 0); 41 registry->RegisterInt64Pref(prefs::kSyncFirstSyncTime, 0);
43 42
44 // All datatypes are on by default, but this gets set explicitly 43 // All datatypes are on by default, but this gets set explicitly
45 // when you configure sync (when turning it on), in 44 // when you configure sync (when turning it on), in
46 // ProfileSyncService::OnUserChoseDatatypes. 45 // ProfileSyncService::OnUserChoseDatatypes.
47 registry->RegisterBooleanPref(prefs::kSyncKeepEverythingSynced, true); 46 registry->RegisterBooleanPref(prefs::kSyncKeepEverythingSynced, true);
48 47
49 syncer::ModelTypeSet user_types = syncer::UserTypes(); 48 syncer::ModelTypeSet user_types = syncer::UserTypes();
50 49
51 // Include proxy types as well, as they can be individually selected, 50 // Include proxy types as well, as they can be individually selected,
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 } 88 }
90 89
91 void SyncPrefs::RemoveSyncPrefObserver(SyncPrefObserver* sync_pref_observer) { 90 void SyncPrefs::RemoveSyncPrefObserver(SyncPrefObserver* sync_pref_observer) {
92 DCHECK(CalledOnValidThread()); 91 DCHECK(CalledOnValidThread());
93 sync_pref_observers_.RemoveObserver(sync_pref_observer); 92 sync_pref_observers_.RemoveObserver(sync_pref_observer);
94 } 93 }
95 94
96 void SyncPrefs::ClearPreferences() { 95 void SyncPrefs::ClearPreferences() {
97 DCHECK(CalledOnValidThread()); 96 DCHECK(CalledOnValidThread());
98 pref_service_->ClearPref(prefs::kSyncLastSyncedTime); 97 pref_service_->ClearPref(prefs::kSyncLastSyncedTime);
99 pref_service_->ClearPref(prefs::kSyncLastPollTime);
100 pref_service_->ClearPref(prefs::kSyncHasSetupCompleted); 98 pref_service_->ClearPref(prefs::kSyncHasSetupCompleted);
101 pref_service_->ClearPref(prefs::kSyncEncryptionBootstrapToken); 99 pref_service_->ClearPref(prefs::kSyncEncryptionBootstrapToken);
102 pref_service_->ClearPref(prefs::kSyncKeystoreEncryptionBootstrapToken); 100 pref_service_->ClearPref(prefs::kSyncKeystoreEncryptionBootstrapToken);
103 101
104 // TODO(nick): The current behavior does not clear 102 // TODO(nick): The current behavior does not clear
105 // e.g. prefs::kSyncBookmarks. Is that really what we want? 103 // e.g. prefs::kSyncBookmarks. Is that really what we want?
106 } 104 }
107 105
108 bool SyncPrefs::HasSyncSetupCompleted() const { 106 bool SyncPrefs::HasSyncSetupCompleted() const {
109 DCHECK(CalledOnValidThread()); 107 DCHECK(CalledOnValidThread());
(...skipping 30 matching lines...) Expand all
140 DCHECK(CalledOnValidThread()); 138 DCHECK(CalledOnValidThread());
141 return base::Time::FromInternalValue( 139 return base::Time::FromInternalValue(
142 pref_service_->GetInt64(prefs::kSyncLastSyncedTime)); 140 pref_service_->GetInt64(prefs::kSyncLastSyncedTime));
143 } 141 }
144 142
145 void SyncPrefs::SetLastSyncedTime(base::Time time) { 143 void SyncPrefs::SetLastSyncedTime(base::Time time) {
146 DCHECK(CalledOnValidThread()); 144 DCHECK(CalledOnValidThread());
147 pref_service_->SetInt64(prefs::kSyncLastSyncedTime, time.ToInternalValue()); 145 pref_service_->SetInt64(prefs::kSyncLastSyncedTime, time.ToInternalValue());
148 } 146 }
149 147
150 base::Time SyncPrefs::GetLastPollTime() const {
151 DCHECK(CalledOnValidThread());
152 return base::Time::FromInternalValue(
153 pref_service_->GetInt64(prefs::kSyncLastSyncedTime));
154 }
155
156 void SyncPrefs::SetLastPollTime(base::Time time) {
157 DCHECK(CalledOnValidThread());
158 pref_service_->SetInt64(prefs::kSyncLastPollTime, time.ToInternalValue());
159 }
160
161 bool SyncPrefs::HasKeepEverythingSynced() const { 148 bool SyncPrefs::HasKeepEverythingSynced() const {
162 DCHECK(CalledOnValidThread()); 149 DCHECK(CalledOnValidThread());
163 return pref_service_->GetBoolean(prefs::kSyncKeepEverythingSynced); 150 return pref_service_->GetBoolean(prefs::kSyncKeepEverythingSynced);
164 } 151 }
165 152
166 void SyncPrefs::SetKeepEverythingSynced(bool keep_everything_synced) { 153 void SyncPrefs::SetKeepEverythingSynced(bool keep_everything_synced) {
167 DCHECK(CalledOnValidThread()); 154 DCHECK(CalledOnValidThread());
168 pref_service_->SetBoolean(prefs::kSyncKeepEverythingSynced, 155 pref_service_->SetBoolean(prefs::kSyncKeepEverythingSynced,
169 keep_everything_synced); 156 keep_everything_synced);
170 } 157 }
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 425
439 void SyncPrefs::SetFirstSyncTime(base::Time time) { 426 void SyncPrefs::SetFirstSyncTime(base::Time time) {
440 pref_service_->SetInt64(prefs::kSyncFirstSyncTime, time.ToInternalValue()); 427 pref_service_->SetInt64(prefs::kSyncFirstSyncTime, time.ToInternalValue());
441 } 428 }
442 429
443 void SyncPrefs::ClearFirstSyncTime() { 430 void SyncPrefs::ClearFirstSyncTime() {
444 pref_service_->ClearPref(prefs::kSyncFirstSyncTime); 431 pref_service_->ClearPref(prefs::kSyncFirstSyncTime);
445 } 432 }
446 433
447 } // namespace sync_driver 434 } // namespace sync_driver
OLDNEW
« no previous file with comments | « components/sync_driver/sync_prefs.h ('k') | sync/engine/sync_scheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698