Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Side by Side Diff: sync/sessions/status_controller.h

Issue 1144443004: Revert of [Sync] Refactoring polling to be reliable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sync/internal_api/test/fake_sync_manager.cc ('k') | sync/sessions/status_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // StatusController handles all counter and status related number crunching and 5 // StatusController handles all counter and status related number crunching and
6 // state tracking on behalf of a SyncSession. 6 // state tracking on behalf of a SyncSession.
7 // 7 //
8 // This object may be accessed from many different threads. It will be accessed 8 // This object may be accessed from many different threads. It will be accessed
9 // most often from the syncer thread. However, when update application is in 9 // most often from the syncer thread. However, when update application is in
10 // progress it may also be accessed from the worker threads. This is safe 10 // progress it may also be accessed from the worker threads. This is safe
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 int num_server_conflicts() const; 49 int num_server_conflicts() const;
50 50
51 // Aggregate sum of all conflicting items over all conflict types. 51 // Aggregate sum of all conflicting items over all conflict types.
52 int TotalNumConflictingItems() const; 52 int TotalNumConflictingItems() const;
53 53
54 // Number of successfully applied updates. 54 // Number of successfully applied updates.
55 int num_updates_applied() const; 55 int num_updates_applied() const;
56 56
57 int num_server_overwrites() const; 57 int num_server_overwrites() const;
58 58
59 // The time at which we started the first sync cycle in this session.
60 base::Time sync_start_time() const { 59 base::Time sync_start_time() const {
60 // The time at which we sent the first GetUpdates command for this sync.
61 return sync_start_time_; 61 return sync_start_time_;
62 } 62 }
63 63
64 // If a poll was performed in this session, the time at which it finished.
65 // Not set if no poll was performed.
66 base::Time poll_finish_time() const {
67 return poll_finish_time_;
68 }
69
70 const ModelNeutralState& model_neutral_state() const { 64 const ModelNeutralState& model_neutral_state() const {
71 return model_neutral_; 65 return model_neutral_;
72 } 66 }
73 67
74 SyncerError last_get_key_result() const; 68 SyncerError last_get_key_result() const;
75 69
76 // Download counters. 70 // Download counters.
77 void increment_num_updates_downloaded_by(int value); 71 void increment_num_updates_downloaded_by(int value);
78 void increment_num_tombstone_updates_downloaded_by(int value); 72 void increment_num_tombstone_updates_downloaded_by(int value);
79 void increment_num_reflected_updates_downloaded_by(int value); 73 void increment_num_reflected_updates_downloaded_by(int value);
(...skipping 10 matching lines...) Expand all
90 void increment_num_successful_commits(); 84 void increment_num_successful_commits();
91 void increment_num_successful_bookmark_commits(); 85 void increment_num_successful_bookmark_commits();
92 void set_num_successful_bookmark_commits(int value); 86 void set_num_successful_bookmark_commits(int value);
93 87
94 // Server communication status tracking. 88 // Server communication status tracking.
95 void set_last_get_key_result(const SyncerError result); 89 void set_last_get_key_result(const SyncerError result);
96 void set_last_download_updates_result(const SyncerError result); 90 void set_last_download_updates_result(const SyncerError result);
97 void set_commit_result(const SyncerError result); 91 void set_commit_result(const SyncerError result);
98 92
99 void UpdateStartTime(); 93 void UpdateStartTime();
100 void UpdatePollTime();
101 94
102 private: 95 private:
103 ModelNeutralState model_neutral_; 96 ModelNeutralState model_neutral_;
104 97
105 // Time the last sync cycle began.
106 base::Time sync_start_time_; 98 base::Time sync_start_time_;
107 99
108 // If a poll was performed, the time it finished. Not set if not poll was
109 // performed.
110 base::Time poll_finish_time_;
111
112 DISALLOW_COPY_AND_ASSIGN(StatusController); 100 DISALLOW_COPY_AND_ASSIGN(StatusController);
113 }; 101 };
114 102
115 } // namespace sessions 103 } // namespace sessions
116 } // namespace syncer 104 } // namespace syncer
117 105
118 #endif // SYNC_SESSIONS_STATUS_CONTROLLER_H_ 106 #endif // SYNC_SESSIONS_STATUS_CONTROLLER_H_
OLDNEW
« no previous file with comments | « sync/internal_api/test/fake_sync_manager.cc ('k') | sync/sessions/status_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698