Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11444013: Get drag and drop working for win aura. (Closed)

Created:
8 years ago by jam
Modified:
8 years ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, tfarina, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Get drag and drop working for win aura. This makes a bunch of bookmark interactive tests pass. BUG=154081 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171898

Patch Set 1 : #

Total comments: 2

Patch Set 2 : fix test and sync #

Patch Set 3 : fix compile #

Patch Set 4 : dont run drag_drop_controller_unittest.cc for now #

Patch Set 5 : make work with WebContents #

Patch Set 6 : fix compile #

Total comments: 2

Patch Set 7 : sync after moving web_contents.h include cleanup to a separate cl #

Patch Set 8 : move DropTargetWin to DesktopDragDropClientWin #

Total comments: 2

Patch Set 9 : fix #

Patch Set 10 : #

Patch Set 11 : Fix bookmarks interactive tests since now that DRWHW::GetLocationOnNativeScreen is fixed ui_control… #

Total comments: 5

Patch Set 12 : add comment #

Patch Set 13 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+525 lines, -50 lines) Patch
M ash/ash.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +12 lines, -0 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +24 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +24 lines, -7 lines 0 comments Download
M ui/aura/ui_controls_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +2 lines, -6 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +6 lines, -6 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -7 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +22 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +6 lines, -2 lines 0 comments Download
A ui/views/widget/desktop_aura/desktop_drag_drop_client_win.h View 1 2 3 4 5 6 7 8 9 1 chunk +59 lines, -0 lines 0 comments Download
A ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc View 1 2 3 4 5 6 7 8 9 1 chunk +73 lines, -0 lines 0 comments Download
A ui/views/widget/desktop_aura/desktop_drop_target_win.h View 1 2 3 4 5 6 7 8 9 1 chunk +81 lines, -0 lines 0 comments Download
A ui/views/widget/desktop_aura/desktop_drop_target_win.cc View 1 2 3 4 5 6 7 8 9 1 chunk +139 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +13 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +37 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jam
8 years ago (2012-12-05 22:06:41 UTC) #1
Ben Goodger (Google)
https://codereview.chromium.org/11444013/diff/5002/ui/views/widget/desktop_aura/desktop_root_window_host_win.h File ui/views/widget/desktop_aura/desktop_root_window_host_win.h (right): https://codereview.chromium.org/11444013/diff/5002/ui/views/widget/desktop_aura/desktop_root_window_host_win.h#newcode241 ui/views/widget/desktop_aura/desktop_root_window_host_win.h:241: scoped_refptr<DropTargetWin> drop_target_; is there a reason this can't be ...
8 years ago (2012-12-05 22:23:19 UTC) #2
jam
https://codereview.chromium.org/11444013/diff/5002/ui/views/widget/desktop_aura/desktop_root_window_host_win.h File ui/views/widget/desktop_aura/desktop_root_window_host_win.h (right): https://codereview.chromium.org/11444013/diff/5002/ui/views/widget/desktop_aura/desktop_root_window_host_win.h#newcode241 ui/views/widget/desktop_aura/desktop_root_window_host_win.h:241: scoped_refptr<DropTargetWin> drop_target_; On 2012/12/05 22:23:19, Ben Goodger (Google) wrote: ...
8 years ago (2012-12-05 23:04:30 UTC) #3
Ben Goodger (Google)
https://codereview.chromium.org/11444013/diff/1038/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc File ui/views/widget/desktop_aura/desktop_root_window_host_win.cc (right): https://codereview.chromium.org/11444013/diff/1038/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc#newcode630 ui/views/widget/desktop_aura/desktop_root_window_host_win.cc:630: if (drop_target_.get()) { but can't we just call through ...
8 years ago (2012-12-06 18:22:27 UTC) #4
jam
https://codereview.chromium.org/11444013/diff/1038/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc File ui/views/widget/desktop_aura/desktop_root_window_host_win.cc (right): https://codereview.chromium.org/11444013/diff/1038/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc#newcode630 ui/views/widget/desktop_aura/desktop_root_window_host_win.cc:630: if (drop_target_.get()) { On 2012/12/06 18:22:28, Ben Goodger (Google) ...
8 years ago (2012-12-06 18:48:02 UTC) #5
Ben Goodger (Google)
https://codereview.chromium.org/11444013/diff/12016/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc File ui/views/widget/desktop_aura/desktop_root_window_host_win.cc (right): https://codereview.chromium.org/11444013/diff/12016/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc#newcode617 ui/views/widget/desktop_aura/desktop_root_window_host_win.cc:617: drag_drop_client_->OnNativeWidgetCreated( this won't work. HandleCreate is sent in response ...
8 years ago (2012-12-06 18:52:55 UTC) #6
jam
https://codereview.chromium.org/11444013/diff/12016/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc File ui/views/widget/desktop_aura/desktop_root_window_host_win.cc (right): https://codereview.chromium.org/11444013/diff/12016/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc#newcode617 ui/views/widget/desktop_aura/desktop_root_window_host_win.cc:617: drag_drop_client_->OnNativeWidgetCreated( On 2012/12/06 18:52:55, Ben Goodger (Google) wrote: > ...
8 years ago (2012-12-06 18:56:50 UTC) #7
jam
ptal, I've updated to the approach you suggested.
8 years ago (2012-12-07 20:28:28 UTC) #8
Ben Goodger (Google)
Sweet! LGTM. One naming comment below: https://codereview.chromium.org/11444013/diff/39008/ash/drag_drop/drag_drop_controller.cc File ash/drag_drop/drag_drop_controller.cc (right): https://codereview.chromium.org/11444013/diff/39008/ash/drag_drop/drag_drop_controller.cc#newcode113 ash/drag_drop/drag_drop_controller.cc:113: // TODO! let's ...
8 years ago (2012-12-07 22:00:26 UTC) #9
jam
https://codereview.chromium.org/11444013/diff/39008/ash/drag_drop/drag_drop_controller.cc File ash/drag_drop/drag_drop_controller.cc (right): https://codereview.chromium.org/11444013/diff/39008/ash/drag_drop/drag_drop_controller.cc#newcode113 ash/drag_drop/drag_drop_controller.cc:113: // TODO! On 2012/12/07 22:00:26, Ben Goodger (Google) wrote: ...
8 years ago (2012-12-07 22:07:29 UTC) #10
Ben Goodger (Google)
8 years ago (2012-12-07 22:58:21 UTC) #11 
https://codereview.chromium.org/11444013/diff/39008/ui/views/widget/desktop_a...
File ui/views/widget/desktop_aura/desktop_drop_target_win.cc (right):

https://codereview.chromium.org/11444013/diff/39008/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_drop_target_win.cc:87: void
DesktopDropTargetWin::Translate(
ok whatever. lgtm.

Powered by Google App Engine
This is Rietveld 408576698