Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: ash/drag_drop/drag_drop_controller.cc

Issue 11444013: Get drag and drop working for win aura. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ash.gyp ('k') | ash/drag_drop/drag_drop_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/drag_drop/drag_drop_controller.cc
===================================================================
--- ash/drag_drop/drag_drop_controller.cc (revision 171879)
+++ ash/drag_drop/drag_drop_controller.cc (working copy)
@@ -106,6 +106,17 @@
if (IsDragDropInProgress())
return 0;
+#if defined(OS_WIN)
+ // TODO(win_ash): need to figure out how this will work in Metro, since
+ // OSExchangeDataProviderAura isn't used in Windows builds. Two alternatives:
+ // 1) Use OSExchangeDataProviderAura in Ash and OSExchangeDataProviderWin
+ // elsewhere. This will complicate creating an ui::OSExchangeData to pass
+ // in more context.
+ // 2) Add methods to get the image and offset in the base interface of these
+ // implementations to get to this data here.
+ NOTIMPLEMENTED();
+ return 0;
+#else
const ui::OSExchangeDataProviderAura& provider =
static_cast<const ui::OSExchangeDataProviderAura&>(data.provider());
// We do not support touch drag/drop without a drag image.
@@ -180,6 +191,7 @@
drag_source_window_->RemoveObserver(this);
drag_source_window_ = NULL;
}
+#endif
return drag_operation_;
}
« no previous file with comments | « ash/ash.gyp ('k') | ash/drag_drop/drag_drop_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698