Remove --enable-strict-site-isolation

Remove --enable-strict-site-isolation from code and comments.

--site-per-process is the new hotness.

BUG=497306
Committed: https://crrev.com/a23a06d63f69cbc7299564847b7b5ce339c513b2
Cr-Commit-Position: refs/heads/master@{#333525}

[ncarter (slow), 2015-06-05 22:45:38]

nick@chromium.org changed reviewers:
+ creis@chromium.org

[ncarter (slow), 2015-06-05 22:45:38]

Please take a look.

[Charlie Reis, 2015-06-05 23:06:18]

Thanks for the cleanup.  LGTM with nits!

https://codereview.chromium.org/1144253003/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_contents.cc (left):

https://codereview.chromium.org/1144253003/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_contents.cc:94: // or if
--enable-strict-site-isolation is specified and the prerendered
Probably keep this comment and just say --site-per-process, since it applies
there as well.

https://codereview.chromium.org/1144253003/diff/20001/content/browser/child_p...
File content/browser/child_process_security_policy_impl.h (left):

https://codereview.chromium.org/1144253003/diff/20001/content/browser/child_p...
content/browser/child_process_security_policy_impl.h:159: bool
CanSendCookiesForOrigin(int child_id, const GURL& gurl);
Yes, deleting this makes sense.  We don't prevent third-party cookies from being
attached to network requests in --site-per-process since that breaks web
compatibility; that's where we differ from --enable-strict-site-isolation.

https://codereview.chromium.org/1144253003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_unittest.cc (right):

https://codereview.chromium.org/1144253003/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_process_host_unittest.cc:37: // the render
process reuse this test explicitly exercises.
nit: renderer process

https://codereview.chromium.org/1144253003/diff/20001/content/browser/site_in...
File content/browser/site_instance_impl_unittest.cc (right):

https://codereview.chromium.org/1144253003/diff/20001/content/browser/site_in...
content/browser/site_instance_impl_unittest.cc:571: // the render process reuse
this test explicitly exercises.
nit: renderer

[ncarter (slow), 2015-06-06 18:24:33]

nick@chromium.org changed reviewers:
+ davidben@chromium.org

[ncarter (slow), 2015-06-06 18:24:34]

+davidben for a comment-only change

https://codereview.chromium.org/1144253003/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_contents.cc (left):

https://codereview.chromium.org/1144253003/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_contents.cc:94: // or if
--enable-strict-site-isolation is specified and the prerendered
On 2015/06/05 23:06:17, Charlie Reis wrote:
> Probably keep this comment and just say --site-per-process, since it applies
> there as well.

Done.

https://codereview.chromium.org/1144253003/diff/20001/content/browser/child_p...
File content/browser/child_process_security_policy_impl.h (left):

https://codereview.chromium.org/1144253003/diff/20001/content/browser/child_p...
content/browser/child_process_security_policy_impl.h:159: bool
CanSendCookiesForOrigin(int child_id, const GURL& gurl);
On 2015/06/05 23:06:18, Charlie Reis wrote:
> Yes, deleting this makes sense.  We don't prevent third-party cookies from
being
> attached to network requests in --site-per-process since that breaks web
> compatibility; that's where we differ from --enable-strict-site-isolation.

Done.

https://codereview.chromium.org/1144253003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_unittest.cc (right):

https://codereview.chromium.org/1144253003/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_process_host_unittest.cc:37: // the render
process reuse this test explicitly exercises.
On 2015/06/05 23:06:18, Charlie Reis wrote:
> nit: renderer process

Done.

https://codereview.chromium.org/1144253003/diff/20001/content/browser/site_in...
File content/browser/site_instance_impl_unittest.cc (right):

https://codereview.chromium.org/1144253003/diff/20001/content/browser/site_in...
content/browser/site_instance_impl_unittest.cc:571: // the render process reuse
this test explicitly exercises.
On 2015/06/05 23:06:18, Charlie Reis wrote:
> nit: renderer

Done.

[ncarter (slow), 2015-06-08 22:25:58]

davidben@: please review chrome/browser/prerender/prerender_contents.cc

[davidben, 2015-06-09 15:15:17]

Oh, I'm sorry, I missed that this got sent to me too! (Figured I was CC'd via
site-isolation-dev or something.)

lgtm

(cbentzel: FYI, that logic is one that's not unlikely to break as Site Isolation
and PlzNavigate progress. Prerender makes a lot of bad assumptions about process
IDs and navigation. I'm not sure we can keep this feature in its orphaned state
indefinitely. crbug/440544 also.)

[ncarter (slow), 2015-06-09 16:14:41]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2015-06-09 16:14:41]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/1144253003/#ps40001
(title: "Charlie's fixes")

[commit-bot: I haz the power, 2015-06-09 16:15:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144253003/40001

[commit-bot: I haz the power, 2015-06-09 18:05:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-09 18:07:43]

Patchset 3 (id:??) landed as
https://crrev.com/a23a06d63f69cbc7299564847b7b5ce339c513b2
Cr-Commit-Position: refs/heads/master@{#333525}