Issue 11437014: Fix crash when signing in to gaia from an incognito tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11437014: Fix crash when signing in to gaia from an incognito tab (Closed)

Created:
8 years ago by Roger Tawa OOO till Jul 10th

Modified:
8 years ago

Reviewers:
csharp, jwd

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix crash when signing in to gaia from incognito tab. BUG=81265 TEST=Try signing in from an incognito tab. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171335

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -9 lines)			Patch
M	chrome/browser/ui/sync/one_click_signin_helper.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View		2 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper_unittest.cc	View	1 2	2 chunks	+16 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/11437014/7003

8 years ago (2012-12-05 16:07:30 UTC) #4

Message was sent while issue was closed.

Change committed as 171335