Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/browser/ui/sync/one_click_signin_helper.h

Issue 11437014: Fix crash when signing in to gaia from an incognito tab (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typo in comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 5 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
6 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 6 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 // Looks for the Google-Accounts-SignIn response header, and if found, 94 // Looks for the Google-Accounts-SignIn response header, and if found,
95 // tries to display an infobar in the tab contents identified by the 95 // tries to display an infobar in the tab contents identified by the
96 // child/route id. 96 // child/route id.
97 static void ShowInfoBarIfPossible(net::URLRequest* request, 97 static void ShowInfoBarIfPossible(net::URLRequest* request,
98 int child_id, 98 int child_id,
99 int route_id); 99 int route_id);
100 100
101 private: 101 private:
102 explicit OneClickSigninHelper(content::WebContents* web_contents); 102 explicit OneClickSigninHelper(content::WebContents* web_contents);
103 friend class content::WebContentsUserData<OneClickSigninHelper>; 103 friend class content::WebContentsUserData<OneClickSigninHelper>;
104 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperTest,
105 ShowInfoBarUIThreadIncognito);
104 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest, CanOfferOnIOThread); 106 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest, CanOfferOnIOThread);
105 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest, 107 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest,
106 CanOfferOnIOThreadIncognito); 108 CanOfferOnIOThreadIncognito);
107 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest, 109 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest,
108 CanOfferOnIOThreadNoIOData); 110 CanOfferOnIOThreadNoIOData);
109 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest, 111 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest,
110 CanOfferOnIOThreadBadURL); 112 CanOfferOnIOThreadBadURL);
111 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest, 113 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest,
112 CanOfferOnIOThreadReferrer); 114 CanOfferOnIOThreadReferrer);
113 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest, 115 FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest,
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 AutoAccept auto_accept_; 168 AutoAccept auto_accept_;
167 SyncPromoUI::Source source_; 169 SyncPromoUI::Source source_;
168 std::string error_message_; 170 std::string error_message_;
169 171
170 scoped_ptr<SigninTracker> signin_tracker_; 172 scoped_ptr<SigninTracker> signin_tracker_;
171 173
172 DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelper); 174 DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelper);
173 }; 175 };
174 176
175 #endif // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 177 #endif // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698