Issue 11434007: mac: Don't write SCMPath into Info.plist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11434007: mac: Don't write SCMPath into Info.plist (Closed)

Created:
8 years ago by Nico

Modified:
8 years ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Don't write SCMPath into Info.plist The key isn't used by anything, the information is redudant with the version number, the other ports can get by without it, and this makes it easier to move mac to the LASTCHANGE file. BUG=161488 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170055

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	build/mac/tweak_info_plist.py	View	1	2 chunks	+4 lines, -6 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

https://codereview.chromium.org/11434007/diff/1002/build/mac/tweak_info_plist.py File build/mac/tweak_info_plist.py (right): https://codereview.chromium.org/11434007/diff/1002/build/mac/tweak_info_plist.py#newcode131 build/mac/tweak_info_plist.py:131: _RemoveKeys(plist, 'SCMPath') This is probably unnecessary paranoia. I can ...

8 years ago (2012-11-28 20:24:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11434007/1002

8 years ago (2012-11-28 20:27:43 UTC) #3

commit-bot: I haz the power

8 years ago (2012-11-28 21:15:16 UTC) #5

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages