Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3517)

Unified Diff: build/mac/tweak_info_plist.py

Issue 11434007: mac: Don't write SCMPath into Info.plist (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac/tweak_info_plist.py
diff --git a/build/mac/tweak_info_plist.py b/build/mac/tweak_info_plist.py
index 05196a81b4f8a19b03338a7136997e2c9e27b991..5c0cf1396b495f7424b6a76758162e6d26ff259a 100755
--- a/build/mac/tweak_info_plist.py
+++ b/build/mac/tweak_info_plist.py
@@ -114,11 +114,11 @@ def _AddVersionKeys(plist, version=None):
def _DoSCMKeys(plist, add_keys):
"""Adds the SCM information, visible in about:version, to property list. If
|add_keys| is True, it will insert the keys, otherwise it will remove them."""
- scm_path, scm_revision = None, None
+ scm_revision = None
if add_keys:
version_info = lastchange.FetchVersionInfo(
default_lastchange=None, directory=TOP)
- scm_path, scm_revision = version_info.url, version_info.revision
+ scm_revision = version_info.revision
# See if the operation failed.
_RemoveKeys(plist, 'SCMRevision')
@@ -127,10 +127,8 @@ def _DoSCMKeys(plist, add_keys):
elif add_keys:
print >>sys.stderr, 'Could not determine SCM revision. This may be OK.'
- if scm_path != None:
- plist['SCMPath'] = scm_path
- else:
- _RemoveKeys(plist, 'SCMPath')
+ # TODO(thakis): Remove this once m25 has reached stable.
+ _RemoveKeys(plist, 'SCMPath')
Nico 2012/11/28 20:24:40 This is probably unnecessary paranoia. I can remov
def _DoPDFKeys(plist, add_keys):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698