mac: Don't write SCMPath into Info.plist

build/mac/tweak_info_plist.py

 #!/usr/bin/env python
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 #
 # Xcode supports build variable substitutions and CPP; sadly, that doesn't work
 # because:
 #
@@ skipping 96 matching lines @@
   # unique that meetings what LS wants.
   plist['CFBundleVersion'] = bundle_version
 
   # Return with no error.
   return True
 
 
 def _DoSCMKeys(plist, add_keys):
   """Adds the SCM information, visible in about:version, to property list. If
   |add_keys| is True, it will insert the keys, otherwise it will remove them."""
-  scm_path, scm_revision = None, None
+  scm_revision = None
   if add_keys:
     version_info = lastchange.FetchVersionInfo(
         default_lastchange=None, directory=TOP)
-    scm_path, scm_revision = version_info.url, version_info.revision
+    scm_revision = version_info.revision
 
   # See if the operation failed.
   _RemoveKeys(plist, 'SCMRevision')
   if scm_revision != None:
     plist['SCMRevision'] = scm_revision
   elif add_keys:
     print >>sys.stderr, 'Could not determine SCM revision.  This may be OK.'
 
-  if scm_path != None:
-    plist['SCMPath'] = scm_path
-  else:
-    _RemoveKeys(plist, 'SCMPath')
+  # TODO(thakis): Remove this once m25 has reached stable.
+  _RemoveKeys(plist, 'SCMPath')

[Nico, 2012/11/28 20:24:40]

This is probably unnecessary paranoia. I can remove this now too I think, but it
doesn't hurt keeping it here either.

 
 
 def _DoPDFKeys(plist, add_keys):
   """Adds PDF support to the document types list. If add_keys is True, it will
   add the type information dictionary. If it is False, it will remove it if
   present."""
 
   PDF_FILE_EXTENSION = 'pdf'
 
   def __AddPDFKeys(sub_plist):
@@ skipping 152 matching lines @@
   # Info.plist will work perfectly well in any plist format, but traditionally
   # applications use xml1 for this, so convert it to ensure that it's valid.
   proc = subprocess.Popen(['plutil', '-convert', 'xml1', '-o', DEST_INFO_PLIST,
                            temp_info_plist.name])
   proc.wait()
   return proc.returncode
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv[1:]))