Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1143363009: [5/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools. (Closed)

Created:
5 years, 6 months ago by horo
Modified:
5 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, kinuko+watch, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[5/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools. This CL removes unused ServiceWorkerHandler::GetClientInfo(). Screenshot: https://code.google.com/p/chromium/issues/detail?id=466871#c65 1/5 chromium: https://codereview.chromium.org/1160133002/ 2/5 blink: https://codereview.chromium.org/1151993003/ 3/5 chromium: https://codereview.chromium.org/1149383004/ 4/5 blink: https://codereview.chromium.org/1164583002/ 5/5 chromium: this CL. Committed: https://crrev.com/0df6e7be1e9de3dc0d3a8b4c5c41dbfe8425d631 Cr-Commit-Position: refs/heads/master@{#335209}

Patch Set 1 : #

Patch Set 2 : s/Client/Target/ #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M content/browser/devtools/protocol/service_worker_handler.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
horo
pfeldman@ Please review this. Thank you.
5 years, 6 months ago (2015-06-15 03:16:17 UTC) #3
pfeldman
lgtm
5 years, 6 months ago (2015-06-15 16:14:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143363009/60001
5 years, 6 months ago (2015-06-19 02:41:50 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 6 months ago (2015-06-19 04:51:16 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 04:52:19 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0df6e7be1e9de3dc0d3a8b4c5c41dbfe8425d631
Cr-Commit-Position: refs/heads/master@{#335209}

Powered by Google App Engine
This is Rietveld 408576698