[4/5 blink] Shows the clients which are controlled by ServiceWorker in DevTools.

[4/5 blink] Shows the clients which are controlled by ServiceWorker in DevTools.

This CL implements blink side JS code.

Screenshot: https://code.google.com/p/chromium/issues/detail?id=466871#c65

1/5 chromium: https://codereview.chromium.org/1160133002/
2/5 blink: https://codereview.chromium.org/1151993003/
3/5 chromium: https://codereview.chromium.org/1149383004/
4/5 blink: This cl.
5/5 chromium: https://codereview.chromium.org/1143363009/

BUG=466871
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197314

[horo, 2015-05-29 08:43:10]

Patchset #1 (id:1) has been deleted

[horo, 2015-05-29 08:50:13]

Patchset #1 (id:20001) has been deleted

[horo, 2015-06-05 04:19:58]

Patchset #2 (id:60001) has been deleted

[horo, 2015-06-05 04:20:03]

Patchset #2 (id:80001) has been deleted

[horo, 2015-06-12 09:28:27]

horo@chromium.org changed reviewers:
+ pfeldman@chromium.org

[horo, 2015-06-12 09:28:28]

pfeldman@
Could you please review this CL?

Thank you.

[pfeldman, 2015-06-12 20:31:35]

lgtm

https://codereview.chromium.org/1164583002/diff/160001/Source/devtools/front_...
File Source/devtools/front_end/sdk/ServiceWorkerManager.js (right):

https://codereview.chromium.org/1164583002/diff/160001/Source/devtools/front_...
Source/devtools/front_end/sdk/ServiceWorkerManager.js:165: * @param {string}
targetId
Here and below {ServiceWorker.TargetID}

https://codereview.chromium.org/1164583002/diff/160001/Source/devtools/front_...
Source/devtools/front_end/sdk/ServiceWorkerManager.js:225: console.error(error);
callback(null); return; here

https://codereview.chromium.org/1164583002/diff/160001/Source/devtools/front_...
Source/devtools/front_end/sdk/ServiceWorkerManager.js:593: this.id =
payload.versionId;
Most of these fields could be private.

https://codereview.chromium.org/1164583002/diff/160001/Source/devtools/front_...
Source/devtools/front_end/sdk/ServiceWorkerManager.js:601:
this.controlledClients.push(payload.controlledClients[i]);
4 spaces, {} around.

[horo, 2015-06-15 03:12:43]

Thank you

https://codereview.chromium.org/1164583002/diff/160001/Source/devtools/front_...
File Source/devtools/front_end/sdk/ServiceWorkerManager.js (right):

https://codereview.chromium.org/1164583002/diff/160001/Source/devtools/front_...
Source/devtools/front_end/sdk/ServiceWorkerManager.js:165: * @param {string}
targetId
On 2015/06/12 20:31:34, pfeldman wrote:
> Here and below {ServiceWorker.TargetID}

Done.

https://codereview.chromium.org/1164583002/diff/160001/Source/devtools/front_...
Source/devtools/front_end/sdk/ServiceWorkerManager.js:225: console.error(error);
On 2015/06/12 20:31:34, pfeldman wrote:
> callback(null); return; here

Done.

https://codereview.chromium.org/1164583002/diff/160001/Source/devtools/front_...
Source/devtools/front_end/sdk/ServiceWorkerManager.js:593: this.id =
payload.versionId;
On 2015/06/12 20:31:34, pfeldman wrote:
> Most of these fields could be private.

All of these fields are used in ServiceWorkersView.js

https://codereview.chromium.org/1164583002/diff/160001/Source/devtools/front_...
Source/devtools/front_end/sdk/ServiceWorkerManager.js:601:
this.controlledClients.push(payload.controlledClients[i]);
On 2015/06/12 20:31:34, pfeldman wrote:
> 4 spaces, {} around.

Done.

[horo, 2015-06-18 02:14:27]

The CQ bit was checked by horo@chromium.org

[horo, 2015-06-18 02:14:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1164583002/#ps180001
(title: "incorporated pfeldman's comment")

[commit-bot: I haz the power, 2015-06-18 02:15:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164583002/180001

[commit-bot: I haz the power, 2015-06-18 03:35:33]

Committed patchset #6 (id:180001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197314

[aaronmullen1988, 2015-06-18 04:27:42]

aaronmullen1988@gmail.com changed reviewers:
+ aaronmullen1988@gmail.com

[aaronmullen1988, 2015-06-18 04:27:43]

lgtm