Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: content/browser/devtools/protocol/service_worker_handler.cc

Issue 1143363009: [5/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/protocol/service_worker_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/service_worker_handler.cc
diff --git a/content/browser/devtools/protocol/service_worker_handler.cc b/content/browser/devtools/protocol/service_worker_handler.cc
index ec8173ff48064f6633794d0d677113aa09c96b0a..475169cf9efaef1069a8b5d5239350e2a4bcaeac 100644
--- a/content/browser/devtools/protocol/service_worker_handler.cc
+++ b/content/browser/devtools/protocol/service_worker_handler.cc
@@ -439,12 +439,6 @@ Response ServiceWorkerHandler::DeliverPushMessage(
return Response::OK();
}
-// TODO(horo): I will remove it in crrev.com/1143363009.
-Response ServiceWorkerHandler::GetTargetInfo(DevToolsCommandId command_id,
- const std::string& target_id) {
- return Response::InternalError("Not implemented yet");
-}
-
Response ServiceWorkerHandler::GetTargetInfo(
const std::string& target_id,
scoped_refptr<TargetInfo>* target_info) {
« no previous file with comments | « content/browser/devtools/protocol/service_worker_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698