Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 1143363005: Revert of [Cast] Compute utilization metrics and add performance overlay. (Closed)

Created:
5 years, 7 months ago by battre
Modified:
5 years, 7 months ago
Reviewers:
hubbe, miu
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Cast] Compute utilization metrics and add performance overlay. (patchset #2 id:40001 of https://codereview.chromium.org/1148233002/) Reason for revert: Reverting due to compile failure on Google Chrome Mac builder: ../../media/cast/sender/h264_vt_encoder_unittest.cc:282:38: error: no viable conversion from 'Callback<typename internal::BindState<typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunnableType, typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunType, internal::TypeList<typename internal::CallbackParamTraits<MetadataRecorder *>::StorageType> >::UnboundRunType>' to 'Callback<void (scoped_ptr<media::cast::SenderEncodedFrame>)>' VideoEncoder::FrameEncodedCallback cb = base::Bind( ^ ~~~~~~~~~~~ ../../base/callback.h:358:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'base::Callback<typename internal::BindState<typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunnableType, typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunType, internal::TypeList<typename internal::CallbackParamTraits<MetadataRecorder *>::StorageType> >::UnboundRunType>' to 'base::Callback<void (scoped_ptr<media::cast::SenderEncodedFrame, base::DefaultDeleter<media::cast::SenderEncodedFrame> >)> &&' for 1st argument class Callback; http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Mac&number=1293 Original issue's description: > [Cast] Compute utilization metrics and add performance overlay. > > Adds computation of two frame-level utilization metrics to the software > VP8 encoder in Cast: deadline utilization and lossy utilization. The > first is a measure of how long the encoding of each frame takes compared > to the frame duration. The second is a measure of the complexity of a > frame, in terms of the quality versus encoded size trade-off. > > In a future change, these utilization metrics will be sent as feedback > signals to the producer of the video frames, allowing the producer to > adjust data volumes based on the consumer's capability throughout a > session. See bug for more details. > > Also, this change adds an overlay display, where frame-level performance > metrics are rendered in the lower-right corner of each video frame just > before it is sent. This provides an "on screen display" of end-to-end > system performance. This is turned on with a command line argument: > --vmodule=performance_metrics_overlay=3 > > BUG=156767 > > Committed: https://crrev.com/d9e741512cd6ea56cefd0173b371d0dd29f0cce5 > Cr-Commit-Position: refs/heads/master@{#330896} TBR=hubbe@chromium.org,miu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=156767 Committed: https://crrev.com/dcd1d5968e79c93d9fe9ca1a523d6f83b94a6ae6 Cr-Commit-Position: refs/heads/master@{#330906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -529 lines) Patch
M media/cast/BUILD.gn View 2 chunks +6 lines, -6 lines 0 comments Download
M media/cast/cast.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M media/cast/net/cast_transport_config.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/receiver/video_decoder_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/cast/sender/external_video_encoder.cc View 2 chunks +1 line, -3 lines 0 comments Download
M media/cast/sender/fake_software_video_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/fake_software_video_encoder.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.cc View 2 chunks +1 line, -4 lines 0 comments Download
D media/cast/sender/performance_metrics_overlay.h View 1 chunk +0 lines, -66 lines 0 comments Download
D media/cast/sender/performance_metrics_overlay.cc View 1 chunk +0 lines, -295 lines 0 comments Download
D media/cast/sender/sender_encoded_frame.h View 1 chunk +0 lines, -46 lines 0 comments Download
D media/cast/sender/sender_encoded_frame.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M media/cast/sender/size_adaptable_video_encoder_base.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/size_adaptable_video_encoder_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/software_video_encoder.h View 3 chunks +2 lines, -2 lines 0 comments Download
M media/cast/sender/video_encoder.h View 2 chunks +1 line, -4 lines 0 comments Download
M media/cast/sender/video_encoder_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/cast/sender/video_encoder_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/video_encoder_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M media/cast/sender/video_sender.h View 3 chunks +1 line, -8 lines 0 comments Download
M media/cast/sender/video_sender.cc View 5 chunks +1 line, -15 lines 0 comments Download
M media/cast/sender/vp8_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/vp8_encoder.cc View 3 chunks +3 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
Created Revert of [Cast] Compute utilization metrics and add performance overlay.
5 years, 7 months ago (2015-05-21 06:42:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143363005/1
5 years, 7 months ago (2015-05-21 06:43:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 06:43:48 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 06:44:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcd1d5968e79c93d9fe9ca1a523d6f83b94a6ae6
Cr-Commit-Position: refs/heads/master@{#330906}

Powered by Google App Engine
This is Rietveld 408576698