Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: media/cast/sender/h264_vt_encoder.cc

Issue 1143363005: Revert of [Cast] Compute utilization metrics and add performance overlay. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/sender/fake_software_video_encoder.cc ('k') | media/cast/sender/performance_metrics_overlay.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/sender/h264_vt_encoder.cc
diff --git a/media/cast/sender/h264_vt_encoder.cc b/media/cast/sender/h264_vt_encoder.cc
index 53aaf658c415061752476f45c4b85243b1f2df05..eb7bc603e35ddfbbea28b961a56c5d613fd2a352 100644
--- a/media/cast/sender/h264_vt_encoder.cc
+++ b/media/cast/sender/h264_vt_encoder.cc
@@ -729,7 +729,7 @@
// frame. VideoToolbox calls the output callback serially, so this is safe.
const uint32 frame_id = ++encoder->last_frame_id_;
- scoped_ptr<SenderEncodedFrame> encoded_frame(new SenderEncodedFrame());
+ scoped_ptr<EncodedFrame> encoded_frame(new EncodedFrame());
encoded_frame->frame_id = frame_id;
encoded_frame->reference_time = request->reference_time;
encoded_frame->rtp_timestamp = request->rtp_timestamp;
@@ -753,9 +753,6 @@
if (has_frame_data)
CopySampleBufferToAnnexBBuffer(sbuf, &encoded_frame->data, keyframe);
- // TODO(miu): Compute and populate the |deadline_utilization| and
- // |lossy_utilization| performance metrics in |encoded_frame|.
-
encoder->cast_environment_->PostTask(
CastEnvironment::MAIN, FROM_HERE,
base::Bind(request->frame_encoded_callback,
« no previous file with comments | « media/cast/sender/fake_software_video_encoder.cc ('k') | media/cast/sender/performance_metrics_overlay.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698