media/cast/sender/external_video_encoder.cc - Issue 1143363005: Revert of [Cast] Compute utilization metrics and add performance overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/sender/external_video_encoder.cc

Issue 1143363005: Revert of [Cast] Compute utilization metrics and add performance overlay. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/cast/sender/external_video_encoder.cc

diff --git a/media/cast/sender/external_video_encoder.cc b/media/cast/sender/external_video_encoder.cc

index 0423ea4730f9e5fcbcf69edacf10b1ae1dd510dc..75ea4b497906eb2bb97fe1a82f1b5b18b64c9480 100644

--- a/media/cast/sender/external_video_encoder.cc

+++ b/media/cast/sender/external_video_encoder.cc

@@ -200,7 +200,7 @@

} else if (!in_progress_frame_encodes_.empty()) {

const InProgressFrameEncode& request = in_progress_frame_encodes_.front();

- scoped_ptr<SenderEncodedFrame> encoded_frame(new SenderEncodedFrame());

+ scoped_ptr<EncodedFrame> encoded_frame(new EncodedFrame());

encoded_frame->dependency = key_frame ? EncodedFrame::KEY :

EncodedFrame::DEPENDENT;

encoded_frame->frame_id = next_frame_id_++;

@@ -216,8 +216,6 @@

}

encoded_frame->data.append(

static_cast<const char*>(output_buffer->memory()), payload_size);

- // TODO(miu): Compute and populate the |deadline_utilization| and

- // |lossy_utilization| performance metrics in |encoded_frame|.

cast_environment_->PostTask(

CastEnvironment::MAIN,

« no previous file with comments | « media/cast/receiver/video_decoder_unittest.cc ('k') | media/cast/sender/fake_software_video_encoder.h » ('j') | no next file with comments »