Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1143333003: Eliminate redundancy in the parameters to NotifyEntryChanged. (Closed)

Created:
5 years, 7 months ago by Avi (use Gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate redundancy in the parameters to NotifyEntryChanged. BUG=369661 TEST=none Committed: https://crrev.com/4717933ac94bf62a680bc8e77d66e43b35b70dec Cr-Commit-Position: refs/heads/master@{#330800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M content/public/browser/navigation_controller.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Avi (use Gerrit)
Peter: the one chrome/ file Charlie: all else
5 years, 7 months ago (2015-05-20 19:14:33 UTC) #2
Peter Kasting
LGTM
5 years, 7 months ago (2015-05-20 19:55:07 UTC) #3
nasko
LGTM
5 years, 7 months ago (2015-05-20 20:41:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143333003/1
5 years, 7 months ago (2015-05-20 20:42:45 UTC) #7
Charlie Reis
LGTM
5 years, 7 months ago (2015-05-20 20:52:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 21:01:32 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 21:02:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4717933ac94bf62a680bc8e77d66e43b35b70dec
Cr-Commit-Position: refs/heads/master@{#330800}

Powered by Google App Engine
This is Rietveld 408576698