Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 1143333003: Eliminate redundancy in the parameters to NotifyEntryChanged. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_vector.h" 10 #include "base/memory/scoped_vector.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 // Ref counted pointer that keeps the FrameNavigationEntry alive as long as 44 // Ref counted pointer that keeps the FrameNavigationEntry alive as long as
45 // it is needed by this node's NavigationEntry. 45 // it is needed by this node's NavigationEntry.
46 scoped_refptr<FrameNavigationEntry> frame_entry; 46 scoped_refptr<FrameNavigationEntry> frame_entry;
47 47
48 // List of child TreeNodes, which will be deleted when this node is. 48 // List of child TreeNodes, which will be deleted when this node is.
49 ScopedVector<TreeNode> children; 49 ScopedVector<TreeNode> children;
50 }; 50 };
51 51
52 static NavigationEntryImpl* FromNavigationEntry(NavigationEntry* entry); 52 static NavigationEntryImpl* FromNavigationEntry(NavigationEntry* entry);
53 static const NavigationEntryImpl* FromNavigationEntry(
54 const NavigationEntry* entry);
53 55
54 // The value of bindings() before it is set during commit. 56 // The value of bindings() before it is set during commit.
55 static int kInvalidBindings; 57 static int kInvalidBindings;
56 58
57 NavigationEntryImpl(); 59 NavigationEntryImpl();
58 NavigationEntryImpl(SiteInstanceImpl* instance, 60 NavigationEntryImpl(SiteInstanceImpl* instance,
59 int page_id, 61 int page_id,
60 const GURL& url, 62 const GURL& url,
61 const Referrer& referrer, 63 const Referrer& referrer,
62 const base::string16& title, 64 const base::string16& title,
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 // persisted, unless specific data is taken out/put back in at save/restore 434 // persisted, unless specific data is taken out/put back in at save/restore
433 // time (see TabNavigation for an example of this). 435 // time (see TabNavigation for an example of this).
434 std::map<std::string, base::string16> extra_data_; 436 std::map<std::string, base::string16> extra_data_;
435 437
436 DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl); 438 DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
437 }; 439 };
438 440
439 } // namespace content 441 } // namespace content
440 442
441 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 443 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/browser/frame_host/navigation_entry_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698