Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: content/public/browser/navigation_controller.h

Issue 1143333003: Eliminate redundancy in the parameters to NotifyEntryChanged. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 // Cancels a repost that brought up a warning. 403 // Cancels a repost that brought up a warning.
404 virtual void CancelPendingReload() = 0; 404 virtual void CancelPendingReload() = 0;
405 // Continues a repost that brought up a warning. 405 // Continues a repost that brought up a warning.
406 virtual void ContinuePendingReload() = 0; 406 virtual void ContinuePendingReload() = 0;
407 407
408 // Returns true if we are navigating to the URL the tab is opened with. 408 // Returns true if we are navigating to the URL the tab is opened with.
409 // Returns false after the initial navigation has committed. 409 // Returns false after the initial navigation has committed.
410 virtual bool IsInitialNavigation() const = 0; 410 virtual bool IsInitialNavigation() const = 0;
411 411
412 // Broadcasts the NOTIFICATION_NAV_ENTRY_CHANGED notification for the given 412 // Broadcasts the NOTIFICATION_NAV_ENTRY_CHANGED notification for the given
413 // entry (which must be at the given index). This will keep things in sync 413 // entry. This will keep things in sync like the saved session.
414 // like the saved session. 414 virtual void NotifyEntryChanged(const NavigationEntry* entry) = 0;
415 virtual void NotifyEntryChanged(const NavigationEntry* entry, int index) = 0;
416 415
417 // Copies the navigation state from the given controller to this one. This 416 // Copies the navigation state from the given controller to this one. This
418 // one should be empty (just created). 417 // one should be empty (just created).
419 virtual void CopyStateFrom(const NavigationController& source) = 0; 418 virtual void CopyStateFrom(const NavigationController& source) = 0;
420 419
421 // A variant of CopyStateFrom. Removes all entries from this except the last 420 // A variant of CopyStateFrom. Removes all entries from this except the last
422 // committed entry, and inserts all entries from |source| before and including 421 // committed entry, and inserts all entries from |source| before and including
423 // its last committed entry. For example: 422 // its last committed entry. For example:
424 // source: A B *C* D 423 // source: A B *C* D
425 // this: E F *G* 424 // this: E F *G*
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
463 462
464 private: 463 private:
465 // This interface should only be implemented inside content. 464 // This interface should only be implemented inside content.
466 friend class NavigationControllerImpl; 465 friend class NavigationControllerImpl;
467 NavigationController() {} 466 NavigationController() {}
468 }; 467 };
469 468
470 } // namespace content 469 } // namespace content
471 470
472 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 471 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698