Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1143303002: NSS: reject DH groups smaller than 1024 bits. (Closed)

Created:
5 years, 7 months ago by agl
Modified:
5 years, 7 months ago
Reviewers:
davidben, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NSS: reject DH groups smaller than 1024 bits. Since some platforms are still using NSS for now, this change mirrors https://boringssl-review.googlesource.com/#/c/4813/ in NSS. BUG=490240 Committed: https://crrev.com/1da1e686a87ad9f95d26786d2b53a1a4c280189f Cr-Commit-Position: refs/heads/master@{#330791}

Patch Set 1 #

Patch Set 2 : include patch file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M net/third_party/nss/README.chromium View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 1 chunk +2 lines, -0 lines 0 comments Download
A net/third_party/nss/patches/dh1024.patch View 1 1 chunk +14 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
agl
5 years, 7 months ago (2015-05-20 18:16:26 UTC) #2
davidben
lgtm
5 years, 7 months ago (2015-05-20 18:22:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143303002/1
5 years, 7 months ago (2015-05-20 18:32:15 UTC) #5
Ryan Sleevi
LGTM thanks for the patch
5 years, 7 months ago (2015-05-20 18:42:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143303002/20001
5 years, 7 months ago (2015-05-20 18:43:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 20:20:41 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 20:21:38 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1da1e686a87ad9f95d26786d2b53a1a4c280189f
Cr-Commit-Position: refs/heads/master@{#330791}

Powered by Google App Engine
This is Rietveld 408576698